Bug 1526018

Summary:	Review Request: bolt - Thunderbolt system daemon
Product:	[Fedora] Fedora	Reporter:	Christian Kellner <ckellner>
Component:	Package Review	Assignee:	Yanko Kaneti <yaneti>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review, yaneti
Target Milestone:	---	Flags:	yaneti: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-02 16:50:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christian Kellner 2017-12-14 15:47:58 UTC

gicmo's scratch build of bolt-0.1-1.fc27.src.rpm for rawhide completed:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=23682724

spec file: https://gist.github.com/gicmo/20f11540c235fc6d98f7dec3a2a97788

Description:
bolt is a system daemon to manage thunderbolt 3 devices via a D-BUS
API. Thunderbolt 3 features different security modes that require
devices to be authorized before they can be used. The D-Bus API can be
used to list devices, enroll them (authorize and store them in the
local database) and forget them again (remove previously enrolled
devices). It also emits signals if new devices are connected (or
removed). During enrollment devices can be set to be automatically
authorized as soon as they are connected.  A command line tool, called
boltctl, can be used to control the daemon and perform all the above
mentioned tasks.

Fedora Account System Username: gicmo
github upstream link: https://github.com/gicmo/bolt

Comment 1 Yanko Kaneti 2017-12-14 16:44:18 UTC

- lacks a license file, both in the spec and in the release tarball

- "The %defattr directive in the %files list SHOULD ONLY be used when setting a non-default value, or to reset to the default value after having set a non-default value." to quote the guidelines

Comment 2 Robert-André Mauchin 🐧 2017-12-14 17:44:33 UTC

 - This file is present twice in %files:

%{_unitdir}/%{name}.service

%{_unitdir}/bolt.service

 - Grab the license file from the GIT repo:

Source1: https://raw.githubusercontent.com/gicmo/bolt/master/COPYING

Comment 3 Christian Kellner 2017-12-14 23:32:35 UTC

Thanks for the reviews! I spotted the missing COPYING file only after the release ... sigh. 
For now I have done what Robert-André suggested.

Updated spec file: https://gist.github.com/gicmo/20f11540c235fc6d98f7dec3a2a97788

New scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23690449

Comment 4 Yanko Kaneti 2017-12-15 08:36:40 UTC

Name is sensible and doesn't conflict
Files don't conflict
License matches source
Builds in mock

APPROVED

Comment 5 Gwyn Ciesla 2017-12-15 17:25:47 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/bolt. You may commit to the branch "f27" in about 10 minutes.

Comment 6 Fedora Update System 2017-12-17 20:14:51 UTC

bolt-0.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0485b38286

Comment 7 Fedora Update System 2017-12-18 22:01:21 UTC

bolt-0.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0485b38286

Comment 8 Fedora Update System 2018-01-02 16:50:25 UTC

bolt-0.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.