Bug 1526056

Please note that some of the dependencies needed for the full functionality were dropped for the moment, so for example the "watch" command does not work ATM, but hopefully, it will be resolved soon.

I updated the guard package to the latest available version and since rubygem-guard is about to lend in Fedora, I enabled that dependency, although not sure how much it helps ...

Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-ascii_binder.git/plain/rubygem-ascii_binder.spec?id=6b2a1926647286b7788b8358fc4cd47d2b44f5a4
SRPM URL: http://people.redhat.com/vondruch/rubygem-ascii_binder-0.1.14-1.fc28.src.rpm

The "asciibinder watch" command is apparently still broken. If I comment out the whole "/usr/share/gems/gems/ascii_binder-0.1.14/Guardfile" file content, the error disappears and the shell is available. Would this help to anything?

BuildRequires: rubygem(trollop) >= 0.1.2

Should be 2.1.2

What's preventing you from packaging the missing deps?

(In reply to Robert-André Mauchin from comment #4)
> BuildRequires: rubygem(trollop) >= 0.1.2
> 
> Should be 2.1.2

Heh, good one. Probably better to drop the version entirely.
 
> What's preventing you from packaging the missing deps?

Mainly doubts that they are really required and for what purpose. And even if they are good for something, probably better to get ascii_binder to Fedora sooner than later even if some parts should not be 100% percent working.

Here is updated version:

Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-ascii_binder.git/plain/rubygem-ascii_binder.spec?id=9f17644089c8a66bfa09cc7356a55b67b805f488
SRPM URL: http://people.redhat.com/vondruch/rubygem-ascii_binder-0.1.14-2.fc28.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=24514805

It fixes the trollop BR and since rubygem-guard-shell is available now in Fedora, it enables the dependency. The guard-livereload is still disabled, since it is not in Fedora and moreover, it requires browser extension. Will see if we will get that into the Fedora.

> # Fix shebang.
> sed -i 's|/usr/bin/env ruby|/usr/bin/ruby|' %{buildroot}%{gem_instdir}/bin/asciibinder
This might not be necessary with the recent shebang rewriting that has been turned on in rawhide. Still needed in lower releases...

> git config --global user.email "you"
> git config --global user.name "Your Name"
Is this necessary?

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ the binary seems to run OK
+ Provides/Requires/BR look OK
+ Packaging:Ruby is followed
+ fedora-review and rpmlint don't show any important errors

rubygem-ascii_binder-doc.noarch: W: spelling-error Summary(en_US) ascii -> ASCII
rubygem-ascii_binder-doc.noarch: W: spelling-error %description -l en_US ascii -> ASCII
I guess that's true.

rubygem-ascii_binder-doc.noarch: W: invalid-url URL: http://asciibinder.org/ <urlopen error [Errno -2] Name or service not known>
Works fine.

rubygem-ascii_binder-doc.noarch: E: version-control-internal-file /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/.gitignore
rubygem-ascii_binder-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/_javascripts/.gitkeep
rubygem-ascii_binder-doc.noarch: E: zero-length /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/_javascripts/.gitkeep
Indeed, those could be dropped but meh.

rubygem-ascii_binder.noarch: W: no-documentation
rubygem-ascii_binder.noarch: W: no-manual-page-for-binary asciibinder
2 packages and 0 specfiles checked; 4 errors, 8 warnings.

Package is APPROVED.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> > # Fix shebang.
> > sed -i 's|/usr/bin/env ruby|/usr/bin/ruby|' %{buildroot}%{gem_instdir}/bin/asciibinder
> This might not be necessary with the recent shebang rewriting that has been
> turned on in rawhide. Still needed in lower releases...

Indeed. That change landed in Fedora 29th. I will drop this.

> > git config --global user.email "you"
> > git config --global user.name "Your Name"
> Is this necessary?

Yes, it is. Git fails when these are not set and git is essential part of ascii_binder workflow and therefore test suite fails without this setup.

> rubygem-ascii_binder-doc.noarch: W: spelling-error Summary(en_US) ascii ->
> ASCII
> rubygem-ascii_binder-doc.noarch: W: spelling-error %description -l en_US
> ascii -> ASCII
> I guess that's true.

It is probably not a good idea to change AsciiBinder and AsciiDoc into upper case ...
 
> rubygem-ascii_binder-doc.noarch: E: version-control-internal-file
> /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/.
> gitignore
> rubygem-ascii_binder-doc.noarch: W: hidden-file-or-dir
> /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/
> _javascripts/.gitkeep
> rubygem-ascii_binder-doc.noarch: E: zero-length
> /usr/share/gems/gems/ascii_binder-0.1.14/features/support/test_distro/
> _javascripts/.gitkeep
> Indeed, those could be dropped but meh.

Hmm, not sure about these. I could drop them, but I think they are part of test project and they corresponds to the similar files in templates directory. I'll rather keep them.

> Package is APPROVED.

Thx for the review and approval.

https://pagure.io/releng/fedora-scm-requests/issue/4403

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-ascii_binder