Bug 1526219

Summary: [RFE] Add RBAC and Tagging Support to Ansible Credentials.
Product: Red Hat CloudForms Management Engine Reporter: John Hardy <jhardy>
Component: UI - OPSAssignee: Hilda Stastna <hstastna>
Status: CLOSED CURRENTRELEASE QA Contact: Pavol Kotvan <pakotvan>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, gblomqui, hkataria, jfrey, jhardy, lavenel, mpovolny, obarenbo, pakotvan
Target Milestone: GAKeywords: FutureFeature, TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1553393 (view as bug list) Environment:
Last Closed: 2019-02-11 14:03:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1553393    

Description John Hardy 2017-12-15 02:29:30 UTC
[RFE] Add RBAC and Tagging Support to Ansible Credentials.

As a user I should only be able to view Credentials that have been enabled for my user permissions.

Comment 3 CFME Bot 2018-02-27 19:57:06 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/8ab4bbf478c5e0527153eb902ca12b5cdb4336e0

commit 8ab4bbf478c5e0527153eb902ca12b5cdb4336e0
Author:     James Wong <jwong>
AuthorDate: Mon Feb 26 11:39:30 2018 -0500
Commit:     James Wong <jwong>
CommitDate: Mon Feb 26 11:39:44 2018 -0500

    Taggable of AutomationManager's authentications/playbooks/repos
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1526219
    https://bugzilla.redhat.com/show_bug.cgi?id=1526218
    https://bugzilla.redhat.com/show_bug.cgi?id=1526217

 app/models/manageiq/providers/automation_manager/authentication.rb       | 1 +
 .../providers/automation_manager/configuration_script_payload.rb         | 1 +
 .../manageiq/providers/automation_manager/configuration_script_source.rb | 1 +
 3 files changed, 3 insertions(+)

Comment 4 James Wong 2018-02-27 20:01:29 UTC
Backend is done. Assigning to UI team...

Comment 6 Hilda Stastna 2018-03-02 13:57:17 UTC
Another PR for making this work:
https://github.com/ManageIQ/manageiq-ui-classic/pull/3507
I will add more commits to that PR daily.

Comment 7 Hilda Stastna 2018-03-02 17:12:37 UTC
Update: tagging already works, but only from the screen containing the list of all credentials

Comment 8 Hilda Stastna 2018-03-05 09:35:30 UTC
Update: tagging and displaying tags in the table works from summary page of any ansible credential

Comment 9 Hilda Stastna 2018-03-05 12:08:49 UTC
Update: already done, just waiting for review

Comment 10 CFME Bot 2018-03-05 22:11:25 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/e06ee9043b49d510df1b748f8f72230da288d627
commit e06ee9043b49d510df1b748f8f72230da288d627
Author:     Hilda Stastna <hstastna>
AuthorDate: Fri Mar  2 08:31:01 2018 -0500
Commit:     Hilda Stastna <hstastna>
CommitDate: Fri Mar  2 08:31:01 2018 -0500

    Add tagging feature for Ansible Credentials

    https://bugzilla.redhat.com/show_bug.cgi?id=1526219

 db/fixtures/miq_product_features.yml | 4 +
 1 file changed, 4 insertions(+)

Comment 11 CFME Bot 2018-03-05 22:13:01 UTC
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/2900b7e7cc6f7050d3ae22a33261c58b9ff117a5
commit 2900b7e7cc6f7050d3ae22a33261c58b9ff117a5
Author:     Hilda Stastna <hstastna>
AuthorDate: Fri Mar  2 08:39:39 2018 -0500
Commit:     Hilda Stastna <hstastna>
CommitDate: Fri Mar  2 08:39:39 2018 -0500

    Add Policy button to enable tagging in Ansible Credentials

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526219

    Add Policy toolbar button to enable tagging in Automation > Ansible > Credentials.

 app/helpers/application_helper/toolbar/ansible_credentials_center.rb | 22 +
 1 file changed, 22 insertions(+)


https://github.com/ManageIQ/manageiq-ui-classic/commit/c5305c4bb6f25a8e7b36357e93c65af92334c4d1
commit c5305c4bb6f25a8e7b36357e93c65af92334c4d1
Author:     Hilda Stastna <hstastna>
AuthorDate: Mon Mar  5 04:31:58 2018 -0500
Commit:     Hilda Stastna <hstastna>
CommitDate: Mon Mar  5 04:31:58 2018 -0500

    Add Policy button to enable tagging of Ansible Credential

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526219

    Add Policy toolbar button to enable tagging of any Ansible Credential
    from its summary page.

 app/helpers/application_helper/toolbar/ansible_credential_center.rb | 16 +
 1 file changed, 16 insertions(+)