Bug 1526402

Summary:	glusterd crashes when 'gluster volume set help' is executed
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	glusterd	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-15 11:23:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xavi Hernandez 2017-12-15 11:34:50 UTC

Description of problem:

A buffer overflow cases a segmentation fault when executing 'gluster volume set help'.

Version-Release number of selected component (if applicable): master


How reproducible:

always if the size of the help is bigger than 51200 bytes.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-12-15 11:44:43 UTC

REVIEW: https://review.gluster.org/19040 (glusterd: Fix buffer overflow in glusterd_get_volopt_content) posted (#1) for review on master by Xavier Hernandez

Comment 2 Worker Ant 2017-12-15 16:44:26 UTC

COMMIT: https://review.gluster.org/19040 committed in master by \"Xavier Hernandez\" <jahernan> with a commit message- glusterd: Fix buffer overflow in glusterd_get_volopt_content

The size of the description of each option in gluster has become
greater than the hardcoded maximum size, causing a buffer overflow
when requesting a list of all options.

This patch uses dynamic memory to store all the information.

Change-Id: I115cb9b55fc440434638bf468a50db055cdf271d
BUG: 1526402
Signed-off-by: Xavier Hernandez <jahernan>

Comment 3 Shyamsundar 2018-03-15 11:23:27 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report.

glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html
[2] https://www.gluster.org/pipermail/gluster-users/