Bug 152651

I'd appreciate some help with packaging rpm2html.  It builds fine, but segfaults
when run.  I'll attach a gdb backtrace in case it's useful to someone.  I've
tried building with normal Psyche GCC as well as gcc296 from compat-gcc,
avoiding binary stripping, building with and without gpg support, but to no
avail, a segfault happens when rpm2html tries to read directory contents.  The
dir contains RPMS signed with my GPG key.

Please note that the rpm2html-1.7 distributed by RH (in Psyche) segfaults for me
as well.

http://cachalot.ods.org/stuff/fedora/wip/rpm2html-1.8.1-1.fedora.1.src.rpm

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

22401a76944cee5eb50277dc661c5564  rpm2html-1.8.1-1.fedora.1.src.rpm
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+YKVw2YzWNbzSQcsRAuomAKCEUPZd6jQ7dE7yMsHwR3VxzhNWNQCbBHA3
4ulfUZ2eiwNlMw3hcpfmEXg=
=Fvah
-----END PGP SIGNATURE-----



------- Additional Comments From ville.skytta 2003-03-02 17:58:16 ----

Oops, it looks like I forgot the backtrace, but here goes:

#0  0x32363665 in ?? ()
#1  0x0805c506 in rpmOpen ()
#2  0x0805c8f6 in rpmOneDirScan ()
#3  0x0805cab4 in rpmDirScan ()
#4  0x0805d48e in rpmDirScanAll ()
#5  0x08057dd2 in main ()
#6  0x420158d4 in __libc_start_main () from /lib/i686/libc.so.6
(gdb)




------- Additional Comments From bugs.michael 2003-05-04 12:37:15 ----

IIRC, Daniel Veillard mentioned in some bug report at Red Hat bugzilla, that he
no longer maintains rpm2html and that it would need to be ported to the newer
RPM libraries. Segfaulting due to API incompatibilities maybe?



------- Additional Comments From ville.skytta 2003-05-04 21:41:13 ----

Yep, most likely :(



------- Additional Comments From bugs.michael 2003-05-05 00:31:40 ----

Since this is about Psyche, on Shrike it fails to compile actually (due to
rpmlib incompat.).




------- Additional Comments From ville.skytta 2003-11-26 12:52:49 ----

Effort dropped ages ago.



------- Additional Comments From fedora-bugs 2004-01-12 19:30:50 ----

I managed to get rpm2html working on Red Hat Linux 8.0 + Fedora Legacy. The
"trick" was removing the "./configure" call from the %build section of the spec
file, moving the configure options over to the "./autogen.sh" call in the %prep
section (note that autogen does call configure with the supplied options, and
this also makes the compilation process faster). After that rpm2html stopped
crashing!

Working packages (both source and binary) are available at
http://rpm.nogin.org/regularly_built/rh80/rpm2html-1.8.2-3.rh8.0.i386.html



------- Additional Comments From bugs.michael 2004-01-13 11:19:34 ----

Unless we define a different build environment for Fedora Legacy:

* Missing "Buildrequires: autoconf, automake"
* Missing "Buildrequires: zlib-devel, bzip2-devel, popt, libxml2-devel"

* Optional missing "Buildrequires: gnupg" (for real /usr/bin/gpg detection, else
it defaults to /usr/bin/gpg)

* Instead of running autogen.sh with arguments, run

aclocal ; automake ; autoconf

Why? Read on.

* After that, run "%configure --with-pgp". That macro takes care of setting
--sysconfdir and many other path definitions, e.g. --prefix and --mandir.

* rpmbuild says:
warning: File listed twice: /usr/share/rpm2html/msg.

Reason: %{_datadir}/rpm2html includes the entire tree below it and hence also
the %{_datadir}/rpm2html/msg.* which is listed in the %files section. You can
drop %{_datadir}/rpm2html/msg.*

* Installation of "msg.*" files into /usr/share/rpm2html is broken and includes
only a single file "/usr/share/rpm2html/msg." (also true for Red Hat's rh80
package!):

  for i in msg.*
  do
    install -m 0644 $i ${RPM_BUILD_ROOT}%{_datadir}/rpm2html/msg.$ll
  done

What is $ll here? It's undefined!

* Simply drop the entire installation section from %install and run "make
DESTDIR=${RPM_BUILD_ROOT} install" only. It does the right thing and makes your
life easier.

* Else rpm2html works for me. :)




------- Additional Comments From bugs.michael 2004-01-13 11:21:26 ----

A %changelog entry would be helpful, too, btw.




------- Additional Comments From warren 2004-01-13 11:27:44 ----

All of Michael's recommendations sound good for Legacy.




------- Additional Comments From bugs.michael 2004-01-14 11:38:43 ----

Investigated the reason for the segfaults. It's RPM_OPT_FLAGS. When compiling
with just -O2 and no arch/cpu specific flags, it doesn't fail.

[...]

My shot at update rpms:

http://xmms-fc.sf.net/rpm2html-1.8.2-1.fedora.src.rpm
http://xmms-fc.sf.net/rpm2html-1.8.2-1.fedora.i386.rpm




------- Additional Comments From ville.skytta 2004-01-18 11:25:04 ----

Created an attachment (id=515)
Fix version

Whee, this actually seems to work on FC1 too ;)  Although it does a lot of
weird things like placing arbitrary limits on %{release} and friends lengths
and "allowed characters" which should really be fixed upstream...

Anyway, I don't have a legacy box to test with so I won't do a further review. 
Here's a tiny patch for a bug that caught my attention though, apply it (if you
think it's worth it ;) and after that (and before running autoconf and friends)
do a "mv rpm2html.h rpm2html.h.in".  Fixes the reported version both in command
line and generated markup.  Will also submit "upstream", wherever that is...



------- Additional Comments From jkeating 2004-05-18 19:13:52 ----

Removing LEGACY keyword, non-bug for stock RPM.



------- Bug moved to this database by dkl 2005-03-30 18:12 -------

This bug previously known as bug 38 at https://bugzilla.fedora.us/
https://bugzilla.fedora.us/show_bug.cgi?id=38
Originally filed under the Fedora Legacy product and Package request component.

Attachments:
Fix version
https://bugzilla.fedora.us/attachment.cgi?action=view&id=515

Unknown version unspecified in product Fedora Legacy. Setting version to "core1".
Unknown priority P5. Setting to default priority "normal".
Unknown platform PC. Setting to default platform "All".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.