Bug 1526662

Summary:	Review Request: python3-dns - DNS toolkit for Python
Product:	[Fedora] Fedora	Reporter:	Avram Lubkin <aviso>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <zebob.m>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zebob.m
Target Milestone:	---	Flags:	zebob.m: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-25 10:38:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Avram Lubkin 2017-12-16 00:24:21 UTC

Spec URL: https://src.fedoraproject.org/rpms/python-dns/raw/epel7/f/python-dns.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5097/23715097/python3-dns-1.12.0GIT99fd864-1.el7.src.rpm
Description: dnspython is a DNS toolkit for Python. It supports almost all record
types. It can be used for queries, zone transfers, and dynamic
updates. It supports TSIG authenticated messages and EDNS0.
Fedora Account System Username: aviso

Comment 1 Avram Lubkin 2017-12-16 00:25:34 UTC

This is to support a Python 3 package for EPEL 7 since the srpm name can't match the RHEL srpm name.

Comment 2 Avram Lubkin 2017-12-16 00:39:35 UTC

Sorry, need to update the SRPM/SPEC, please wait before evaluating

Comment 3 Avram Lubkin 2017-12-16 00:52:03 UTC

Spec is the same, SRPM is https://aviso.fedorapeople.org/python3-dns-1.15.0-5.el7.centos.src.rpm

Comment 4 Robert-André Mauchin 🐧 2017-12-16 14:55:07 UTC

 - Not needed anymore:

%clean
rm -rf %{buildroot}

 - Not needed anymore, it is the default:

%defattr(-,root,root,-)

 - The LICENSE should be included with the %license macro, not %doc:

%doc ChangeLog examples
%license LICENSE

 - Add you own entry to the %changelog

 - the SPEC name should be python3-dns:

python3-dns.src: E: invalid-spec-name

Fedora-review is not working well with this packaging naming trick, so I've checked manually:
 - License OK
 - Builds in EPEL7 Koji
 - No rpmlint issue.

Comment 5 Avram Lubkin 2018-01-09 19:45:49 UTC

Thanks for the review. Sorry for the delay.
Updated spec and srpm
Spec URL: https://aviso.fedorapeople.org/python3-dns.spec
SRPM URL: https://aviso.fedorapeople.org/python3-dns-1.15.0-6.el7.centos.src.rpm

Comment 6 Robert-André Mauchin 🐧 2018-01-09 19:50:51 UTC

 - In %files you didn't remove:

%defattr(-,root,root,-)

Comment 7 Avram Lubkin 2018-01-09 19:58:38 UTC

Oops, sorry
Spec URL: https://aviso.fedorapeople.org/python3-dns.spec
SRPM URL: https://aviso.fedorapeople.org/python3-dns-1.15.0-7.el7.centos.src.rpm

Comment 8 Robert-André Mauchin 🐧 2018-01-09 20:18:39 UTC

Spec URL was not updated, Spec in SRPM is good though. Package is approved.

Comment 9 Gwyn Ciesla 2018-01-10 03:32:33 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python3-dns

Comment 10 Fedora Update System 2018-01-10 05:56:30 UTC

python3-dns-1.15.0-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-72b2cdeba8

Comment 11 Fedora Update System 2018-01-10 14:07:43 UTC

python3-dns-1.15.0-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-72b2cdeba8

Comment 12 Fedora Update System 2018-01-25 10:38:51 UTC

python3-dns-1.15.0-7.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.