Bug 1528166
| Summary: | Log source IP and port on requests to the authorization module | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-provider-ovn | Reporter: | Mor <mkalfon> | ||||
| Component: | provider | Assignee: | Dominik Holler <dholler> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mor <mkalfon> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | unspecified | CC: | bugs, danken, dholler, mkalfon, ylavi | ||||
| Target Milestone: | ovirt-4.2.1 | Flags: | rule-engine:
ovirt-4.2+
ylavi: exception+ |
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | No Doc Update | |||||
| Doc Text: |
undefined
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-02-12 11:48:54 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Isn't it a duplicate of bug 1527894 ? No, the other one is for the provider, this one is for the authorization module. Dominik already added a patch. Verified on: RHV 4.2.1.1-0.1.el7 ovirt-provider-ovn-1.2.4-1.el7ev.noarch This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018. Since the problem described in this bug report should be resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1370751 [details] logs Description of problem: We currently do not log the IP address of client requests to the authorization module (in ovirt-provider-ovn.log). It is hard to track the source of the requests without looking at client side logs. I suggest adding a log for each message that can be linked to client sessions. For example: <DATE> <TIME> [<CLIENT_IP, CLIENT_SOURCE_PORT>] <MSG_TYPE> : <MSG> Version-Release number of selected component (if applicable): ovirt-provider-ovn-1.2.2-1.el7ev.noarch How reproducible: 100% Steps to Reproduce: 1. Request a token and use it to send request to the provider (GET, POST, etc.) Actual results: 2017-12-20 20:09:57,053 Starting server 2017-12-20 20:09:57,053 Version: 1.2.2-1 2017-12-20 20:09:57,054 Build date: 20171212155302 2017-12-20 20:09:57,054 Githash: c2d4257 2017-12-20 20:19:00,638 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:00,776 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:12,868 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:13,246 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:13,981 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:14,148 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:14,295 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:14,675 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:14,805 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:14,915 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:15,051 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:15,279 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:15,420 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:15,529 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:15,650 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com 2017-12-20 20:19:15,721 Starting new HTTPS connection (1): network-ge-2.scl.lab.tlv.redhat.com Expected results: See description. Additional info: