Bug 1528567

Summary: [RFE] Provide 'dig-holes' functionality for fallocate
Product: Red Hat Enterprise Linux 7 Reporter: Steffen Froemer <sfroemer>
Component: util-linuxAssignee: Karel Zak <kzak>
Status: CLOSED ERRATA QA Contact: Radka Brychtova <rskvaril>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.4CC: alekcejk, fkrska, ovasik, rskvaril
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: util-linux-2.23.2-56.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 10:52:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1546552, 1549617, 1551061    

Description Steffen Froemer 2017-12-22 07:26:19 UTC 
1. Proposed title of this feature request
Provide the support of feature 'dig-holes' for utility 'fallocate'. This is already available upstream.


3. What is the nature and description of the request?
The customer would like to sparsify possibility of fallocate. For this, the 'dig-holes' option is required.


4. Why does the customer need this? (List the business requirements here)
This would be very handy as the customer need to (re-)sparsify files already several times.
This can be applied to VM images and others. Also it could be used for simulation file outputs, which are up to 3TB in size.

5. How would the customer like to achieve this? (List the functional requirements here)
Downstream the already existing fallocate version from upstream package.


6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
# calling `fallocate -d` will support dig-holes functionality and should _not_ print out "invalid option"


7. Is there already an existing RFE upstream or in Red Hat Bugzilla?
It's already supported by Upstream version. In version 2.25 of util-linux, it seems it was included the first time.

https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/sys-utils/fallocate.1?h=stable%2Fv2.25



8. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?
RHEL7


9. Is the sales team involved in this request and do they have any additional input?
no


10. List any affected packages or components.
util-linux-2.23.2-43.el7_4.2.x86_64


11. Would the customer be able to assist in testing this functionality if implemented?
yes
Comment 7 Karel Zak 2018-06-06 10:04:40 UTC 
I have backported all fallocate from upstream.

It seems better to use this already tested version than create a special version for RHEL7 with --dig-holes only. The new version also provides support for new fallocate(2) flags:

    * add --dig-holes
    * add --collapse-range
    * add --insert-range
    * add --zero-range
Comment 12 errata-xmlrpc 2018-10-30 10:52:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3178