Bug 1528985

Summary: tenant quota [memory] not honoured for PROJECTs
Product: Red Hat CloudForms Management Engine Reporter: Reartes Guillermo <greartes>
Component: AutomateAssignee: Tina Fitzgerald <tfitzger>
Status: CLOSED CURRENTRELEASE QA Contact: Dave Johnson <dajohnso>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.0CC: abellott, bascar, cpelland, dmetzger, fdewaley, gmccullo, greartes, jprause, mkanoor, obarenbo, tfitzger, vparekh, wfitzger
Target Milestone: GA   
Target Release: 5.8.5   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-17 12:58:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1572700    
Attachments:
Description Flags
tenant quota for project, before exceeding quota
none
tenant quota for project, after exceeding quota
none
3 services ordered (only room for 1) , 1 accepted and 2 denied -> OK none

Description Reartes Guillermo 2017-12-25 14:20:44 UTC 
Description of problem:

Hi,

I noticed that tenant memory quota is not honoured for projects.
I did not test with tenant at this moment, since i am using projects.
I did test storage and cpu tenant quotas and they do work fine.


Version-Release number of selected component (if applicable):
CFME 5.8.2.3
vCenter 6.5

How reproducible:
always

Steps to Reproduce:
1. create project "A", apply prov_scope tag
2. make sure that the project has resources (provider/hosts/templates, etc also tagged with the correct provision scope tag)
3. set tenant quotas. (specifically set memory quota, for example 9gb)
4. provision a vm with 5 gb, it will report correctly that there are 4gb remaining
5. provision another vm, with 13gb (for example) and it will provision without error. The quota memory will be negative.

Actual results:
tenant memory quota can be exceeded

Expected results:
tenant memory quota must be enforced

Additional info:
I cannot upload any logs at this moment.
I attached screen-shots.
Comment 2 Reartes Guillermo 2017-12-25 14:21:31 UTC 
Created attachment 1372160 [details]
tenant quota for project, before exceeding quota
Comment 3 Reartes Guillermo 2017-12-25 14:21:57 UTC 
Created attachment 1372161 [details]
tenant quota for project, after exceeding quota
Comment 4 Greg McCullough 2018-01-03 14:39:03 UTC 
Tina - Can you please review and determine if this is an issue with the automate enforcement or a tenant model issue for the core.
Comment 6 William Fitzgerald 2018-01-04 18:43:22 UTC 
Reartes,

We need the following information:

1. Was the 1st provision request completed before you submitted the 2nd request?
2. Can you confirm this is vm provisioning and not service provisioning?
3. Can you please send the automation logs or maybe snippets from the automation logs for the following quota methods:  used, requested and validate_quota.   
4. Did you see quota exceeded for cpu and storage?
5. We tested on version 5.8.2.3 and quota was exceeded corretly.
6. Are you using a service dialog?  

Thanks

Billy
Comment 7 Tina Fitzgerald 2018-01-25 20:45:02 UTC 
Hi Guillermo,

We recently made a fix for active provisions, but I'm not sure if that is the issue you're experiencing here.

Acvive provision ticket: 
https://bugzilla.redhat.com/show_bug.cgi?id=1489507

Can you send us the evm.log and automation.log?

Thanks,
Tina
Comment 9 Tina Fitzgerald 2018-03-09 20:41:20 UTC 
Any update on this issue?
Comment 10 William Fitzgerald 2018-04-12 15:16:21 UTC 
Any update on this issue?
Comment 11 Reartes Guillermo 2018-04-25 15:38:31 UTC 
Hi,

We are going to revisit / re-test this soon.

Thanks in advance.
Comment 12 Tina Fitzgerald 2018-07-18 14:24:49 UTC 
Hi Reartes,


I believe this issue has been resolved.

Can you re-test and provide an update?

Thanks,
Tina
Comment 14 Reartes Guillermo 2018-08-16 19:30:43 UTC 
Hi,

Sorry for the delay.

I checked it in my lab with CF 4.5.x with RHV 4.1 with remaining quota for 1 VM.

ordered 1 vm and immediately ordered two more and only one of the 3 got accepted. The other 3 were denied correctly.

Sadly i cannot test it with VMWare.

But it looks fixed, thanks.
Comment 15 Reartes Guillermo 2018-08-16 19:32:52 UTC 
Created attachment 1476502 [details]
3 services ordered (only room for 1) , 1 accepted and 2 denied -> OK

CF is 4.5 (5.8.4.5) with RHV 4.1.x