Bug 1529027

Summary:	Review Request: python-send2trash - Python library to natively send files to Trash
Product:	[Fedora] Fedora	Reporter:	William Moreno <williamjmorenor>
Component:	Package Review	Assignee:	Björn 'besser82' Esser <besser82>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	besser82, mhroncok, package-review
Target Milestone:	---	Flags:	besser82: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-23 21:43:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1173410, 1532430

Description William Moreno 2017-12-26 01:11:02 UTC

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-send2trash.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-send2trash-1.4.2-0.fc28.src.rpm
Description: Python library to natively send files to Trash
Fedora Account System Username: williamjmorenor

Comment 1 William Moreno 2017-12-26 01:15:57 UTC

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-send2trash.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-send2trash-1.4.2-1.fc28.src.rpm

Comment 2 Björn 'besser82' Esser 2017-12-29 17:45:52 UTC

Package looks good to me, but `%{python3_sitelib}/*`…  You shoudn't greedy-glob there, since you might own the `__pycache__` directory, which is owned by python3 itself.

Please fix `%{?python_provide:%python_provide python2-%send2trash}` (the `%` in package name) during import!

Package APPROVED!

Comment 3 Björn 'besser82' Esser 2017-12-29 17:52:51 UTC

Maybe you could have a look at one of my packages waiting for review in exchange?

https://bugzilla.redhat.com/show_bug.cgi?id=1529352
https://bugzilla.redhat.com/show_bug.cgi?id=1529593
https://bugzilla.redhat.com/show_bug.cgi?id=1529705

Comment 4 Gwyn Ciesla 2018-01-04 14:07:49 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-send2trash. You may commit to the branch "f27" in about 10 minutes.

Comment 5 Fedora Update System 2018-01-06 04:47:10 UTC

python-send2trash-1.4.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d427e6a4fe

Comment 6 Fedora Update System 2018-01-06 21:10:14 UTC

python-send2trash-1.4.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d427e6a4fe

Comment 7 Iryna Shcherbina 2018-01-09 13:07:31 UTC

*** Bug 1532588 has been marked as a duplicate of this bug. ***

Comment 8 Fedora Update System 2018-01-23 21:43:30 UTC

python-send2trash-1.4.2-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.