Bug 1529488
| Summary: | entries not getting cleared post healing of softlinks (stale entries showing up in heal info) | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Ravishankar N <ravishankar> | |
| Component: | disperse | Assignee: | Ravishankar N <ravishankar> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | aspandey, bugs, nchilaka, pkarampu, ravishankar | |
| Target Milestone: | --- | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-4.0.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1527309 | |||
| : | 1534842 1534847 1534848 (view as bug list) | Environment: | ||
| Last Closed: | 2018-03-15 11:24:00 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1527309 | |||
| Bug Blocks: | 1534842, 1534847, 1534848 | |||
|
Description
Ravishankar N
2017-12-28 10:59:27 UTC
REVIEW: https://review.gluster.org/19070 (posix: delete stale gfid handles in nameless lookup) posted (#2) for review on master by Ravishankar N COMMIT: https://review.gluster.org/19070 committed in master by \"Ravishankar N\" <ravishankar> with a commit message- posix: delete stale gfid handles in nameless lookup ..in order for self-heal of symlinks to work properly (see BZ for details). Change-Id: I9a011d00b07a690446f7fd3589e96f840e8b7501 BUG: 1529488 Signed-off-by: Ravishankar N <ravishankar> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report. glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html [2] https://www.gluster.org/pipermail/gluster-users/ Just recording what was happening without the fix, with the test in the description so that its easier without going through all review comments in the patch/ trying it out again. When we delete the symlink from the brick (and not the .glusterfs hardlink to it) and do look up from mount ,name heal will create a new inode. Thus the .glusterfs entry and the symlink are no longer hardlinks to each other. This will cause metadata self-heal (setfattr) on the sink to fail: ----------------------------------------------------------------------------- [2018-07-13 08:56:45.834709] E [posix-handle.c:334:posix_is_malformed_link] (--> /usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x1ee)[0x7f15b63622b0] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10b1a)[0x7f15a7b7db1a] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10cb5)[0x7f15a7b7dcb5] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x1108b)[0x7f15a7b7e08b] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x8a39)[0x7f15a7b75a39] ))))) 0-patchy-posix: malformed internal link FILE for /d/backends/patchy2/.glusterfs/53/4a/534ac265-b7f4-4a72-b621-6cc1c770b133 [2018-07-13 08:56:45.834784] E [MSGID: 113097] [posix-helpers.c:704:posix_istat] 0-patchy-posix: Failed to create handle path for 534ac265-b7f4-4a72-b621-6cc1c770b133/ [Stale file handle] [2018-07-13 08:56:45.835132] E [posix-handle.c:334:posix_is_malformed_link] (--> /usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x1ee)[0x7f15b63622b0] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10b1a)[0x7f15a7b7db1a] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x10cb5)[0x7f15a7b7dcb5] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x1108b)[0x7f15a7b7e08b] (--> /usr/local/lib/glusterfs/4.2dev/xlator/storage/posix.so(+0x2a18b)[0x7f15a7b9718b] ))))) 0-patchy-posix: malformed internal link FILE for /d/backends/patchy2/.glusterfs/53/4a/534ac265-b7f4-4a72-b621-6cc1c770b133 [2018-07-13 08:56:45.835176] E [MSGID: 113091] [posix-inode-fd-ops.c:321:posix_setattr] 0-patchy-posix: Failed to create inode handle for path /SOFTLINK [2018-07-13 08:56:45.835202] E [MSGID: 113018] [posix-inode-fd-ops.c:327:posix_setattr] 0-patchy-posix: setattr (lstat) on <null> failed [2018-07-13 08:56:45.835300] I [MSGID: 115072] [server-rpc-fops_v2.c:1612:server4_setattr_cbk] 0-patchy-server: 13110: SETATTR /SOFTLINK (534ac265-b7f4-4a72-b621-6cc1c770b133), client: CTX_ID:b242a09f-a32b-4019-b42b-7b8830e458fc-GRAPH_ID:0-PID:15159-HOST:ravi3-PC_NAME:patchy-client-2-RECON_NO:-0, error-xlator: - ----------------------------------------------------------------------------- v1 of the patch tried to fix the issue by deleting the stale .glusterfs entry during posix_symlink () (sent during selfheal) v2 of the patch onwards fixes it by deleting it in lookup. |