Bug 1530026

Summary: [RFE][UI] Remove external network selection on add host window
Product: [oVirt] ovirt-engine Reporter: Mor <mkalfon>
Component: BLL.NetworkAssignee: Dominik Holler <dholler>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: low Docs Contact:
Priority: low    
Version: 4.2.0.2CC: bugs, danken, dholler, mburman, mmirecki, mtessun
Target Milestone: ovirt-4.4.0Keywords: FutureFeature, Reopened
Target Release: ---Flags: pm-rhel: ovirt-4.4+
mtessun: planning_ack+
pm-rhel: devel_ack+
pm-rhel: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: sync-to-jira
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:00:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1638675    
Bug Blocks:    
Attachments:
Description Flags
add host screenshot none

Description Mor 2018-01-01 09:45:09 UTC
Created attachment 1375109 [details]
add host screenshot

Description of problem:
External network provider tab on add host window should be removed. A user could end up having host with external network provider that is different than what is defined in the cluster level.

Version-Release number of selected component (if applicable):
RHV 4.2.0.2-0.1.el7

How reproducible:
100%

Steps to Reproduce:
1. New host on cluster --> Check for additional tab 'External provider'.

Actual results:
Appears.

Expected results:
Should be removed.

Additional info:

Comment 1 Mor 2018-01-01 09:46:24 UTC
* 'Network provider'

Comment 2 Dominik Holler 2018-01-03 08:02:08 UTC
If we are managing the external network provider of a host completely at the cluster level, we can remove the possibility to change the provider of a single host.

@Mor: How should the neutron interface mappings individual for a host be handled. Can they be removed, too?

Comment 3 Mor 2018-01-03 10:18:48 UTC
What do you mean by Neutron interface mappings? If you referring to 'external_network_provider_configurations', I'm not sure if it's unnecessary (I don't know if anyone else uses it). We have another bug in REST https://bugzilla.redhat.com/show_bug.cgi?id=1528297 with the problem that install (reinstall) doesn't trigger OVN deployment on non-OVN host that resides on OVN cluster. Can we remove it and change the behaviour of install to consider cluster level setting?

Comment 4 Dominik Holler 2018-01-03 10:43:16 UTC
> What do you mean by Neutron interface mappings? 

https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.2-beta/html/administration_guide/chap-external_providers#Adding_an_External_Network_Provider
Table 11.2. Add Provider: General Settings
This "Interface Mappings" might be individual per host.
If they are individual per host, we still require the tab.

> If you referring to
> 'external_network_provider_configurations', I'm not sure if it's
> unnecessary (I don't know if anyone else uses it). 

'external_network_provider_configurations' is the container on REST-API to store such per-host information.
From my point of view, it would be good to discuss in this bug if per-host settings of network providers are still required. 

> We have another
> bug in REST https://bugzilla.redhat.com/show_bug.cgi?id=1528297 with
> the problem that install (reinstall) doesn't trigger OVN deployment
> on non-OVN host that resides on OVN cluster. Can we remove it and
> change the behaviour of install to consider cluster level setting?

Sure, this is the end of the path. Before we have to ensure that managing the external network provider at the cluster level works completely, including changing the provider, deploying and undeploying of the provider.

Comment 5 Michael Burman 2018-04-26 08:37:49 UTC
(In reply to Dominik Holler from comment #4)
> > What do you mean by Neutron interface mappings? 
> 
> https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.2-
> beta/html/administration_guide/chap-
> external_providers#Adding_an_External_Network_Provider
> Table 11.2. Add Provider: General Settings
> This "Interface Mappings" might be individual per host.
> If they are individual per host, we still require the tab.
> 
> > If you referring to
> > 'external_network_provider_configurations', I'm not sure if it's
> > unnecessary (I don't know if anyone else uses it). 
> 
> 'external_network_provider_configurations' is the container on REST-API to
> store such per-host information.
> From my point of view, it would be good to discuss in this bug if per-host
> settings of network providers are still required. 
> 
> > We have another
> > bug in REST https://bugzilla.redhat.com/show_bug.cgi?id=1528297 with
> > the problem that install (reinstall) doesn't trigger OVN deployment
> > on non-OVN host that resides on OVN cluster. Can we remove it and
> > change the behaviour of install to consider cluster level setting?
> 
> Sure, this is the end of the path. Before we have to ensure that managing
> the external network provider at the cluster level works completely,
> including changing the provider, deploying and undeploying of the provider.

Hi Dominik, 

- Managing the external network provider at the cluster level works completely with install and re-install for deploy.
- undeploy? do you mean removing the packages? i don't think you are going to do it from what i know. 
- change provider? you mean to another ovn provider? or neutron provider?

Comment 6 Dominik Holler 2018-06-13 09:18:03 UTC
(In reply to Michael Burman from comment #5)
> (In reply to Dominik Holler from comment #4)
> Hi Dominik, 
> 
> - change provider? you mean to another ovn provider? or neutron provider?

Yes, if we change the default networking provider of a cluster, the change is currently not propagated to the hosts.

> - undeploy? do you mean removing the packages? i don't think you are going
> to do it from what i know. 

Yes, if the host is removed, the ovn-controller on the host is still connected to the ovn-central.

> - Managing the external network provider at the cluster level works
> completely with install and re-install for deploy.

But I am convinced now that the external network provider tab on add host window should be removed, including the neutron-deployment by oVirt.

Comment 7 Dominik Holler 2018-10-31 08:13:06 UTC
still required in 4.3

Comment 8 Sandro Bonazzola 2019-06-10 12:05:12 UTC
Reopening for 4.4 inclusion

Comment 9 Michael Burman 2019-10-23 13:55:24 UTC
Verified on - rhvm-4.4.0-0.4.master.el7.noarch

Comment 10 Sandro Bonazzola 2020-05-20 20:00:39 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.