Bug 1530162
| Summary: | Viewer should be able to view and process template for external creation flow | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Yadan Pei <yapei> |
| Component: | Management Console | Assignee: | Robb Hamilton <rhamilto> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadan Pei <yapei> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.9.0 | CC: | aos-bugs, jforrest, jokerman, mmccomas, spadgett, yapei |
| Target Milestone: | --- | ||
| Target Release: | 3.9.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: The UI did not validate whether or not a user had permissions to create in a selected project during step one of create from URL.
Consequence: If the user did not have permission to create in the selected project, a somewhat confusing error occurred upon clicking the next button as the form was considered valid since a project had been selected, but the user did not have permissions to create in the selected project.
Fix: Upon selecting a project, the form now checks to see if the user has permissions to add the the project; if not, an inline error message is displayed.
Result: The user is given immediate feedback if (s)he does not have permission to create in a selected project.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-24 15:56:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yadan Pei
2018-01-02 08:04:36 UTC
I'm pretty sure this was the intentional design so that the user doesn't start filling out a form they won't be able to submit. The user does not have the authority to process templates in that namespace, we have to flag that somewhere. We could potentially do better and warn them at the point where they selected the project. Similar to what we are now doing in the new add to project dialogs. For what it's worth, the behavior is consistent with the old catalog (e.g., /project/user1project/create) as create from url simply advances the user in to the old catalog create flow. I wonder if the simple fix is to remove view-only projects from create from url's choose existing project dropdown (or disable them in the dropdown). If you can't create in the project, no point letting you select the project? It's an expensive check. If you have a lot of projects, it's not practical to filter the list up front unfortunately. We found the inconsistent behavior in automation testing, in OCP 3.7, viewer was able to go on to fill out the form and get error "An error occurred processing the template" when he submit the creation. It is better if we could keep consistent behavior? I see the message "You are not authorized to add to this project." with the "Create" button disabled in the new 3.7 template dialog. Is that not what you see? PR to resolve: https://github.com/openshift/origin-web-console/pull/2622 (In reply to Samuel Padgett from comment #5) > I see the message "You are not authorized to add to this project." with the > "Create" button disabled in the new 3.7 template dialog. Is that not what > you see? Attached gif is what I see when creating from url with viewer Robb's fix from comment #6 should make the two consistent where you see the error when picking the project. Yeah, I will give a test after getting a testable puddle Same issue with bug 1510786 Move to VERIFIED |