Bug 1530211

Summary: 2.12.91-2 makes truetype fonts in xterm look bad
Product: [Fedora] Fedora Reporter: dac.override
Component: fontconfigAssignee: Akira TAGOH <tagoh>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ajax, alexl, dac.override, fonts-bugs, i18n-bugs, john.j5live, mclasen, pnemade, rhughes, rstrode, sandmann, tagoh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-04 13:08:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
FC_DEBUG=8 xterm with 2.12.6-4
none
FC_DEBUG=8 xterm with 2.12.91-2
none
FC_DEBUG=7 xterm with 2.12.6-4
none
FC_DEBUG=7 xterm with 2.12.91-2 none

Description dac.override 2018-01-02 09:35:01 UTC
Description of problem:
with 2.12.91-2 xterm looks unnatural with truetype fonts (stretched) downgrading to 2.12.6-4 fixes the issue

Version-Release number of selected component (if applicable):
2.12.91-2

How reproducible:
start xterm, in the menu select "truetype fonts"

Steps to Reproduce:
1.
2.
3.

Actual results:
stretched

Expected results:
not stretched

Additional info:

Comment 1 Akira TAGOH 2018-01-02 09:59:56 UTC
did you see any different result of fc-match between 2.12.6-4 and 2.12.91-2? can you see any error or warning messages on the terminal when you run xterm?

If you can't see any difference for the above, please attach both logs of FC_DEBUG=8 xterm with 2.12.6-4 and 2.12.91-2.

Comment 2 dac.override 2018-01-02 10:21:01 UTC
Created attachment 1375599 [details]
FC_DEBUG=8 xterm with 2.12.6-4

FC_DEBUG=8 xterm with 2.12.6-4

Comment 3 dac.override 2018-01-02 10:22:13 UTC
Created attachment 1375601 [details]
FC_DEBUG=8 xterm with 2.12.91-2

FC_DEBUG=8 xterm with 2.12.91-2

Comment 4 dac.override 2018-01-02 10:25:17 UTC
When i do a diff -u, this kind of stands out

+       variable: False(w)

Comment 5 Akira TAGOH 2018-01-02 10:53:34 UTC
That shouldn't affect on xterm I suppose.

When you revert fontconfig to 2.12.6, did you also revert freetype too?

Comment 6 dac.override 2018-01-02 10:55:42 UTC
No, just fontconfig

Comment 7 Akira TAGOH 2018-01-02 12:51:27 UTC
Oops, sorry, I meant FC_DEBUG=7.

Comment 8 dac.override 2018-01-02 13:28:00 UTC
Created attachment 1375722 [details]
FC_DEBUG=7 xterm with 2.12.6-4

Comment 9 dac.override 2018-01-02 13:28:59 UTC
Created attachment 1375723 [details]
FC_DEBUG=7 xterm with 2.12.91-2

Comment 10 Akira TAGOH 2018-01-03 09:54:50 UTC
Thanks. I've tracked it down. matching rules which was added during <include> was evaluated prior to rules added before <include>. so even though xterm is requesting "mono" - which is usually corrected to "monospace" by the rule in fonts.conf - 2.12.91 is adding "sans-serif" because none of "sans-serif", "serif", "monospace" is in the pattern, then evaluating a rule to replace "mono" to "monospace" at the end. so 2.12.91 is returning a sans-serif font instead of monospace.

Anyway, will fix that shortly.

Comment 11 Akira TAGOH 2018-01-04 13:08:36 UTC
should be fixed in 2.12.92-1. please test.

Comment 12 dac.override 2018-01-04 13:11:51 UTC
Confirmed. Thanks