Bug 1530919

Summary:	[RFE]Include a vars directory instead of only single config.yml file and not hard code the path
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	RFEs	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukas Svaty <lsvaty>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	bugs, sradco, trichard
Target Milestone:	ovirt-4.2.2	Keywords:	FutureFeature
Target Release:	1.1.3	Flags:	rule-engine: ovirt-4.2? rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-metrics-1.1.3-1.el7ev	Doc Type:	Enhancement
Doc Text:	There is now a vars directory for Metrics, instead of a single config.yml file, and the path is not hard coded. You can add a variable file to /etc/config.yml.d/, and it will be used in the Ansible playbook.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-03-29 11:07:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1475135

Description Shirly Radco 2018-01-04 07:44:09 UTC

Description of problem:
Add a directory /etc/ovirt-engine-metrics/config.yml.d and read all *.yml files from it. 
This way a program can add a file there automatically without overwriting a user's manual changes.

Also, have the patch to oVirt metrics config.yml file. Process by make and use PKG_SYSCONF_DIR.

Comment 1 Yaniv Kaul 2018-01-04 08:47:38 UTC

Is this a CodeChange (and why do we need a BZ for it?)
If it's RFE, it's lacking the '[RFE]' prefix we use.
what is the target milestone?

Comment 2 Yaniv Kaul 2018-01-11 13:33:25 UTC

Pushing to 4.2.2. If it's ready before - great.

Comment 3 Lukas Svaty 2018-03-07 14:16:25 UTC

verified in ovirt-engine-metrics-1.1.3.2-1.el7ev.noarch

Comment 4 Sandro Bonazzola 2018-03-29 11:07:06 UTC

This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.