Bug 1530971

Summary: Broken footer in alerts
Product: Red Hat CloudForms Management Engine Reporter: Dmitry Misharov <dmisharo>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, hkataria, lavenel, mhradil, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: Regression, TestOnly, ZStream
Target Release: 5.10.0   
Hardware: All   
OS: All   
Whiteboard: ui:control
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1553317 (view as bug list) Environment:
Last Closed: 2019-02-11 13:59:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1553317    
Attachments:
Description Flags
Screenshot of the bug none

Description Dmitry Misharov 2018-01-04 10:34:07 UTC
Created attachment 1376798 [details]
Screenshot of the bug

Description of problem:
Paginator is visible in alerts editing screen, "Save" and "Cancel" buttons are visible on all alerts screen. 
 
Version-Release number of selected component (if applicable):
5.9.0.15.20180103231404_ee61a82

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Control/Explorer.
2. Open Alerts accordion.
3. Click Configuration/Add a New Alert.

Actual results:
Paginator is still visible.

Expected results:
Paginator should not be visible.

Comment 6 CFME Bot 2018-02-26 14:59:04 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/6ff65d861c37fd3e44b4f8c633b8992431879edf

commit 6ff65d861c37fd3e44b4f8c633b8992431879edf
Author:     Martin Hradil <mhradil>
AuthorDate: Fri Feb 23 12:36:57 2018 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Fri Feb 23 12:47:57 2018 +0000

    MiqPolicy - remove form buttons when cancelling a form or sucessfully saving/adding
    
    explicitly by passing `:remove_form_buttons => true` to `replace_right_cell`
    
    not seeing any previous mechanism to handle this in miq_policy,
    the `handle_bottom_cell` mechanism used elsewhere doesn't work when transitiononing to a non-GTL screen
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530971

 app/controllers/miq_policy_controller.rb                 |  4 +++-
 app/controllers/miq_policy_controller/alert_profiles.rb  |  4 ++--
 app/controllers/miq_policy_controller/alerts.rb          |  4 ++--
 app/controllers/miq_policy_controller/conditions.rb      | 10 +++++-----
 app/controllers/miq_policy_controller/events.rb          |  4 ++--
 app/controllers/miq_policy_controller/miq_actions.rb     |  4 ++--
 app/controllers/miq_policy_controller/policies.rb        |  6 +++---
 app/controllers/miq_policy_controller/policy_profiles.rb |  4 ++--
 8 files changed, 21 insertions(+), 19 deletions(-)

Comment 8 Dmitry Misharov 2018-06-26 09:18:20 UTC
Fixed and verified in 5.10.0.1.20180619163011_900fdc4.