Bug 1531048

Summary: Reverting to snapshots causes qemu to crash.
Product: [Fedora] Fedora Reporter: Matěj Týč <matyc>
Component: qemuAssignee: Fedora Virtualization Maintainers <virt-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 27CC: amit, awilliam, berrange, cfergeau, dwmw2, itamar, pbonzini, rduda, rjones, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-2.10.1-3.fc27 qemu-2.10.2-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-27 20:06:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Python script to reproduce the crash. none

Description Matěj Týč 2018-01-04 13:20:17 UTC 
Created attachment 1376932 [details]
Python script to reproduce the crash.

Description of problem:

Reverting to snapshots causes qemu to fail.

Version-Release number of selected component (if applicable):

qemu-kvm.x86_64 2:2.10.1-2.fc27 fails

qemu-kvm.x86_64 2:2.9.1-2.fc26 DOESN'T fail (i.e. it is a regression)

How reproducible:

Either run the following commands in virsh, or execute the attached Python script.

Steps to Reproduce:
1. Create a VM called "domain".
2a. Execute the following virsh commands:

    start domain
    snapshot-create-as domain --name first
    snapshot-create-as domain --name second
    snapshot-revert domain second
    snapshot-revert domain first

2b. Run the attached script.


Actual results:

There is a message "error: Unable to read from monitor: Connection reset by peer"
The VM log says

...
2018-01-04T13:13:28.702765Z qemu-system-x86_64: -chardev pty,id=charserial0: char device redirected to /dev/pts/8 (label charserial0)
qemu-system-x86_64: /builddir/build/BUILD/qemu-2.10.1/util/qemu-thread-posix.c:397: qemu_event_set: Assertion `ev->initialized' failed.
2018-01-04 13:13:45.119+0000: shutting down, reason=crashed

Expected results:

There is no crash.

Additional info:

This issue seems to be loosely related (the log message is the same):
https://bugzilla.redhat.com/show_bug.cgi?id=1508799
Comment 1 Adam Williamson 2018-03-22 20:03:21 UTC 
I'm also hitting this with openQA tests; ones that try to load a snapshot twice die suddenly due to this.

I believe 1508799 is actually exactly the same issue, so we clearly have a fix: can the fix be applied to Fedora, please?
Comment 2 Adam Williamson 2018-03-22 21:54:10 UTC 
OK, since the commit ID was specified in 1508799, I'm just doing it myself. :P Update for F27 coming soon. F26, F28 and Rawhide should not be affected.
Comment 3 Fedora Update System 2018-03-23 01:53:22 UTC 
qemu-2.10.1-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-38a277227c
Comment 4 Adam Williamson 2018-03-23 02:02:24 UTC 
Fix confirmed in testing here.
Comment 5 Fedora Update System 2018-03-23 17:47:03 UTC 
qemu-2.10.1-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-38a277227c
Comment 6 Fedora Update System 2018-03-27 20:06:12 UTC 
qemu-2.10.1-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2018-08-01 09:19:04 UTC 
qemu-2.10.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6c1be5e1c8
Comment 8 Fedora Update System 2018-08-01 15:44:36 UTC 
qemu-2.10.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6c1be5e1c8
Comment 9 Fedora Update System 2018-08-24 07:11:03 UTC 
qemu-2.10.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.