Bug 1531161

Summary: [Regression] Quota check for users errors out with "no implicit conversion of nil into String" for service provisioning
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: AutomateAssignee: William Fitzgerald <wfitzger>
Status: CLOSED ERRATA QA Contact: Vatsal Parekh <vparekh>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: dajohnso, gmccullo, jhardy, mkanoor, obarenbo, simaishi, smallamp, tfitzger, vparekh, wfitzger
Target Milestone: GAKeywords: Regression, ZStream
Target Release: 5.8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.8.3.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1509977 Environment:
Last Closed: 2018-02-28 13:12:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1509977    
Bug Blocks:    

Comment 3 CFME Bot 2018-01-04 17:25:32 UTC 
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/7ab886b409944b92e466f6de74754e6863729957

commit 7ab886b409944b92e466f6de74754e6863729957
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Dec 19 20:38:18 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jan 4 12:24:26 2018 -0500

    Merge pull request #16693 from tinaafitz/miq_provision_email_fix
    
    Fix email issue in miq_provision_quota_mixin active_provision by_owner method.
    (cherry picked from commit 748ba9b820a5bc14e23c34c6c7edfbd56053ea1b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531161

 app/models/mixins/miq_provision_quota_mixin.rb               | 5 ++---
 spec/models/miq_provision_request_spec.rb                    | 6 ++++++
 spec/models/service_template_provision_request_quota_spec.rb | 6 ++++++
 3 files changed, 14 insertions(+), 3 deletions(-)
Comment 4 CFME Bot 2018-01-04 18:47:29 UTC 
New commit detected on ManageIQ/manageiq-content/fine:
https://github.com/ManageIQ/manageiq-content/commit/5bb99090f2599cbd7138047d5ad9698d17a4b588

commit 5bb99090f2599cbd7138047d5ad9698d17a4b588
Author:     Greg McCullough <gmccullo>
AuthorDate: Wed Dec 20 09:19:11 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jan 4 13:45:32 2018 -0500

    Merge pull request #230 from billfitzgerald0120/user_quota_email
    
    Check for both owner email and requester email for user quota.
    (cherry picked from commit 25317bff448819df562122d670999db6b2813b94)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1531161

 .../QuotaMethods.class/__methods__/used.rb         | 32 +++++++++----
 .../QuotaMethods.class/__methods__/used_spec.rb    | 54 ++++++++++++++++++++--
 2 files changed, 75 insertions(+), 11 deletions(-)
Comment 5 Vatsal Parekh 2018-01-16 08:57:16 UTC 
This works only after email is assigned to the user
Able to verify on Version 5.8.3.1.20180115183240_323eabe
Comment 8 errata-xmlrpc 2018-02-28 13:12:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0374