Bug 1531173

Summary: Backport fix for assertion failure to set too long ipv4.dhcp-client-id with internal/systemd DHCP plugin
Product: Red Hat Enterprise Linux 7 Reporter: Thomas Haller <thaller>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.5CC: atragler, bgalvani, fgiudici, lmiksik, lrintel, rkhan, sukulkar, thaller, vbenes
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.10.2-5.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 13:35:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thomas Haller 2018-01-04 18:14:45 UTC
internal's/systemd's DHCP plugin asserts that the IPv4 DHCP client-id is no longer then 132 bytes.

Reproducer:

enable internal DHCP plugin in NetworkManager.conf:

[main]
dhcp=internal


Restart NM.


  nmcli connection modify "$NAME" \
      ipv4.dhcp-client-id \
      "$(printf '=%.0s' {1..133})"
  nmcli connection up "$NAME"



Note that crash/assertion failure.


While dhcp=internal is not enabled by default on RHEL, I think we still should fix this.


Request backport of https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=41a89aeebac146000de97b778800e755db29568f

Comment 2 Thomas Haller 2018-01-04 18:19:35 UTC
>   nmcli connection modify "$NAME" \
>      ipv4.dhcp-client-id \
>      "$(printf '=%.0s' {1..133})"

note the crash with 133 chars or more, not with 132 :)

Comment 5 Vladimir Benes 2018-02-06 21:28:50 UTC
tested under all arches in CI

Comment 8 errata-xmlrpc 2018-04-10 13:35:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778