Bug 1531303

Summary:	ae_max_retries does not show the correct value after one retry if called through multiple relations each limited by different max retries counts
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.8.0	CC:	cpelland, fdewaley, mkanoor, obarenbo, tfitzger
Target Milestone:	GA
Target Release:	5.9.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	5.9.0.16	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1529735	Environment:
Last Closed:	2018-03-01 13:23:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:	1529735
Bug Blocks:

Comment 2 CFME Bot 2018-01-04 23:13:18 UTC

New commit detected on ManageIQ/manageiq-automation_engine/gaprindashvili:
https://github.com/ManageIQ/manageiq-automation_engine/commit/37c9baca8a6c8539e00aa077e0cec97080a5ddc6

commit 37c9baca8a6c8539e00aa077e0cec97080a5ddc6
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Thu Jan 4 08:56:05 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jan 4 18:11:27 2018 -0500

    Merge pull request #137 from tinaafitz/fix_ae_state_max_retries
    
    Fix Automate State Machine ae_max_retries root object value.
    (cherry picked from commit 19e39c48d865f2f041dadc97f9376b40debf5b6e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531303

 .../engine/miq_ae_engine/miq_ae_state_info.rb                  |  2 +-
 .../engine/miq_ae_engine/miq_ae_state_machine.rb               |  2 +-
 spec/engine/miq_ae_state_machine_multi_spec.rb                 | 10 ++++++----
 3 files changed, 8 insertions(+), 6 deletions(-)

Comment 3 Milan Falešník 2018-02-07 14:30:52 UTC

Verified in 5.9.0.19 against 5.9.0.14. The first state as stated in the updated reproducer steps had the number of the parent state machine in .14. In .19, it had the correct one.

Comment 6 errata-xmlrpc 2018-03-01 13:23:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380