Bug 1531503

Summary: dracut generates wrong initfamfs when lvm.conf containing 'command_names = 1'
Product: Red Hat Enterprise Linux 7 Reporter: Jose Castillo <jcastillo>
Component: dracutAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team-automation>
Severity: urgent Docs Contact:
Priority: medium    
Version: 7.5CC: dracut-maint-list, fkrska, jstodola, jvavra, lnykryn
Target Milestone: rcKeywords: Patch, Reproducer
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: dracut-033-546.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 11:26:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1549617, 1551061    
Attachments:
Description Flags
proposed patch
none
second version based on upstream code none

Description Jose Castillo 2018-01-05 11:13:38 UTC 
Description of problem:

The mkinitrd script is not taking into account command_names
from LVM's configuration. This parameter can modify the output of 
an LVM command, and therefore the parsing can go wrong, generating initramfs with no LVM and no device-mapper, and causing issues at boot time.

Version-Release number of selected component (if applicable):
dracut-033-502.el7.x86_64, but I've checked the code in 7.5 and the problem is still there.

How reproducible:
Always.

Steps to Reproduce:
1. Modify /etc/lvm/lvm.conf and change 'command_names = 0' to 'command_names = 1'. You don't need to edit 'prefix" at all.
2. Re-create the initramfs with 'dracut -f'
3. Boot the server.

Actual results:
The server will go into emergency mode.

Expected results:
The server should boot without problems.

Additional info:
This is very similar to the issue reported in bz#593096 . The patch attached here is based in that one, but in our case I had to modify dracut-functions.sh.
Comment 2 Jose Castillo 2018-01-05 11:14:39 UTC 
Created attachment 1377439 [details]
proposed patch
Comment 6 Jose Castillo 2018-02-01 14:51:42 UTC 
Created attachment 1389542 [details]
second version based on upstream code
Comment 7 Jose Castillo 2018-02-01 14:55:02 UTC 
Lukáš, I've posted a new version of the patch based on upstream code I backported. 
After running more tests in Fedora with the code from 'dracutdevs' git, I found that it actually didn't show the issue at all. After backporting the changes you can see in the patch, the problem was fixed in RHEL 7. 
Does this new patch look good to you?
I'll build a rpm soon so it can be tested by QA.
Comment 8 Lukáš Nykrýn 2018-02-01 15:23:43 UTC 
Yep, looks good to me. The only problem is that we are passed beta right now, so only blockers and exceptions are accepted to rhel-7.5.
Comment 11 Lukáš Nykrýn 2018-06-14 08:31:15 UTC 
https://github.com/dracutdevs/dracut/commit/15384bcedb8002440e1327e97cd9c139af8a32dd -> post
Comment 14 Jakub Vavra 2018-07-23 09:55:40 UTC 
Looks fixed in dracut-033-547.el7.x86_64. (RHEL-7.6-20180720.9)
Comment 16 errata-xmlrpc 2018-10-30 11:26:36 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3232