Bug 1531582

Summary:	Review Request: perl-Attean - Semantic web framework
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Attean-0.018-1.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-01-09 16:36:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2018-01-05 15:00:01 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Attean/perl-Attean.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Attean/perl-Attean-0.017-1.fc28.src.rpm
Description:
Attean provides APIs for parsing, storing, querying, and serializing semantic
web (RDF and SPARQL) data.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-01-08 14:01:46 UTC

FIX: Please update the module to the latest version 0.18.
FIX: Either unbundle the ./inc files and build-require the Module::Install*
     modules whose functions are called from Makefile.PL or build-require
     dependencies of the bundled code.

Please correct all 'FIX' issues and provide new spec file.

Comment 2 Petr Pisar 2018-01-08 15:38:47 UTC

I upgraded the package.

Spec URL: https://ppisar.fedorapeople.org/perl-Attean/perl-Attean.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Attean/perl-Attean-0.018-1.fc28.src.rpm

Comment 3 Jitka Plesnikova 2018-01-09 10:00:39 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok.

$ rpm -qp --requires perl-Attean-0.018-1.fc28.noarch.rpm | sort | uniq -c
$ rpm -qp --requires perl-Attean-tests-0.018-1.fc28.noarch.rpm | sort | uniq -c
The list of dependencies is a bit long, I don't add it there.
Binary requires are Ok.

$ rpm -qp --provides perl-Attean-0.018-1.fc28.noarch.rpm | sort | uniq -c
$ rpm -qp --provides perl-Attean-tests-0.018-1.fc28.noarch.rpm | sort | uniq -c
The list of provides is a bit long, I don't add it there.
Binary provides are Ok.

$ rpmlint perl-Attean.spec perl-Attean-0.018-1.fc28.src.rpm perl-Attean-0.018-1.fc28.noarch.rpm perl-Attean-tests-0.018-1.fc28.noarch.rpm
perl-Attean.noarch: W: no-manual-page-for-binary attean_parse
perl-Attean.noarch: W: no-manual-page-for-binary attean_query
perl-Attean-tests.noarch: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 3 warnings. 
Rpmlint is ok

The package looks good.
Approved.

Comment 4 Gwyn Ciesla 2018-01-09 13:22:39 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Attean

Comment 5 Petr Pisar 2018-01-09 16:36:47 UTC

Thank you for the review and the repository.