Bug 1531609

Summary: undefined method 'value' in 12-check_capsule_tar.rb when running satellite-installer
Product: Red Hat Satellite Reporter: Evgeni Golov <egolov>
Component: InstallationAssignee: Evgeni Golov <egolov>
Status: CLOSED ERRATA QA Contact: jcallaha
Severity: high Docs Contact:
Priority: unspecified    
Version: UnspecifiedCC: bbuckingham, bkearney, egolov
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: katello-installer-base-3.0.0.100-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-05 13:55:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Evgeni Golov 2018-01-05 16:16:55 UTC 
Description of problem:
The fix for #1525544 tries to read non-existing values, leading to an error in the katello-installer:

/usr/share/katello-installer-base/hooks/pre_validations/12-check_capsule_tar.rb:10:in
`block (4 levels) in load': undefined method `value' for nil:NilClass
(NoMethodError)

Version-Release number of selected component (if applicable):
katello-installer-base-3.0.0.98-1.el7sat.noarch.rpm

How reproducible:
100%

Steps to Reproduce:
1. run satellite-installer --scenario satellite

Actual results:
[install-rhel-7] /usr/share/katello-installer-base/hooks/pre_validations/12-check_capsule_tar.rb:10:in `block (4 levels) in load': undefined method `value' for nil:NilClass (NoMethodError)
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hooking.rb:34:in `instance_eval'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hooking.rb:34:in `block (4 levels) in load'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hook_context.rb:13:in `instance_exec'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hook_context.rb:13:in `execute'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hooking.rb:51:in `block in execute'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hooking.rb:49:in `each'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/hooking.rb:49:in `execute'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/kafo_configure.rb:125:in `execute'
[install-rhel-7] 	from /usr/share/gems/gems/clamp-0.6.2/lib/clamp/command.rb:67:in `run'
[install-rhel-7] 	from /usr/share/gems/gems/clamp-0.6.2/lib/clamp/command.rb:125:in `run'
[install-rhel-7] 	from /usr/share/gems/gems/kafo-0.7.6.1/lib/kafo/kafo_configure.rb:148:in `run'
[install-rhel-7] 	from /sbin/satellite-installer:12:in `<main>'

Expected results:
Installs OK

Additional info:
#1525544 is marked as fixed in 6.2.13, but the code seems to be missing as it only ships katello-installer-base-3.0.0.97-1.el7sat.noarch.rpm
the intention behind pulling #1525544 into 6.2.z was to get the absolute path for the certs tar in the answers file, not to allow relative paths in the cli options, which 6.2 accepts anyways.
Comment 5 jcallaha 2018-01-10 19:23:51 UTC 
Verified in Satellite 6.2.14. 

At least 6 Satellite installations have completed successfully, on both RHEL 6 and 7, without any indication of this error.

Further Capsule installations are also passing without issue.
Comment 8 errata-xmlrpc 2018-02-05 13:55:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0273