Bug 1532018

Summary: engine requires tenant name for External Network Provider in RHV 4.2.1
Product: [oVirt] ovirt-engine Reporter: Mor <mkalfon>
Component: BLL.NetworkAssignee: Dominik Holler <dholler>
Status: CLOSED CURRENTRELEASE QA Contact: Mor <mkalfon>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.2.1CC: bugs, lveyde, mkalfon, myakove
Target Milestone: ovirt-4.2.1Keywords: Automation, Regression
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.2.1.1 Doc Type: No Doc Update
Doc Text:
undefined
 Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-12 11:56:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Mor 2018-01-07 13:20:58 UTC 
Description of problem:
Tenant name for default provider: 'ovirt-provider-ovn' in 4.2.1 became mandatory  field after upgrade from RHV 4.2.0. If you try to delete the default provider and create a new one with tenant name 'tenant', it is not possible to do so. Engine throws the following error: 
2018-01-07 14:53:54,936+02 ERROR [org.ovirt.engine.core.bll.provider.TestProviderConnectivityCommand] (default task-16) [6d4fe473-0df2-4487-901a-06a840062544] Command 'org.ovirt.engine.core.bll.provider.TestProviderConnectivityCommand' failed: EngineException: (Failed with error PROVIDER_FAILURE and code 5050)

Version-Release number of selected component (if applicable):
RHV 4.2.1-0.2.el7

How reproducible:
100%

Steps to Reproduce:
On edit of 'ovirt-provider-ovn', you cannot change settings on it.
1. Try to edit 'ovirt-provider-ovn' --> tenant name is a mandatory field, which does not accept values. Also valid one: 'tenant'.

On delete of 'ovirt-provider-ovn', you cannot re-add it:
1. Delete 'ovirt-provider-ovn'.
2. Try to add new 'ovirt-provider-ovn' with the same settings, it is the same as edit.

Actual results:
UI error & engine error.

Expected results:
Tenant name should not be required.

Additional info:
Comment 1 Mor 2018-01-07 13:22:40 UTC 
Created attachment 1378073 [details]
logs
Comment 2 Dan Kenigsberg 2018-01-07 15:44:27 UTC 
Please always provide versions of relevant components. ovirt-engine and ovirt-provider-ovn in this case.

Why do you believe that this is an engine bug? the attached ovirt-provider-ovn.log seems to end before the relevant time.
Comment 3 Mor 2018-01-07 17:17:31 UTC 
The reason why this bug seem on engine code is because if you actually enter a valid tenant, only engine logs an error about it, ovirt-provider-ovn did not log any error.

RPM versions:
ovirt-provider-ovn: ovirt-provider-ovn-driver-1.2.3-1.el7ev.noarch
ovirt-engine: ovirt-engine-4.2.1-0.2.el7.noarch

NOTE: I forgot to add on steps to reproduce. I reproduced the error by using the test (connection) button.
Comment 4 Red Hat Bugzilla Rules Engine 2018-01-11 15:31:03 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 5 Meni Yakove 2018-01-12 10:57:28 UTC 
Moving back to MODIFIED since we don't have d/s build with the fix yet.
Comment 6 Mor 2018-01-14 08:37:59 UTC 
Verified on:
4.2.1.1-0.1.el7
Comment 7 Sandro Bonazzola 2018-02-12 11:56:36 UTC 
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.