Bug 1532674

Summary: Engine should update neutron that binding host has been changed after VM migration with neutron network
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Marcin Mirecki <mmirecki>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: medium Docs Contact:
Priority: high    
Version: 4.2.0CC: bugs, lveyde, ylavi
Target Milestone: ovirt-4.2.2Flags: rule-engine: ovirt-4.2+
ylavi: exception+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.2.2.1 Doc Type: Bug Fix
Doc Text:
This change is only valid when a vm having vnic connected to an external network is migrated. After a successful migration, the engine will the external network provider about the fact that the vnic should now be bound on another host. The request to the external provider will update the binding:host_id value of the port.
 Story Points: ---
Clone Of:
: 1549030 1549033 (view as bug list) Environment:
Last Closed: 2018-03-29 11:14:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1549030, 1549033    
Attachments:
Description Flags
Logs none

Description Michael Burman 2018-01-09 14:50:53 UTC 
Description of problem:
Engine should update neutron that binding host has been changed after VM migration with neutron network.

During the testing done to certify the ospd12 with RHV, i have found that when migratin a VM that has a neutron network, engine doesn't update neutron that the binding host has been changed and the port's state reported as DOWN in neutron.
Engine should do what nova doing and update neutron after VM migration with the new binding host.
Note, that although this bug, the VM remain operational and i can ping it and from it. 

Version-Release number of selected component (if applicable):
openstack-neutron-11.0.1-7.el7ost.noarch
Red Hat OpenStack Platform release 12.0 Beta (Pike)
rhv-4.2.1-0.2.el7
vdsm-4.20.11-1.el7ev

How reproducible:
100%

Steps to Reproduce:
1. Add ospd12 to RHV 4.2 - See BZ 1518370 for the flow
2. Add 2 rhv nodes with neutron roles and neutron agents configured and Create 2 VMs
3. After the setup is up and you have neutron networks in RHV, start VM1 on node1 with neutron network and check the port's state. Ping the VM2(on same node)
4. Migrate VM to node2 and ping VM2  

Actual results:

3. Port is ACTIVE and ping is ok - 

Port state before migration:
(overcloud) [root@overcloud-controller-0 ~]# openstack port show f4f2a451-45c2-4204-b6f6-682b19cc1894
+-----------------------+--------------------------------------------------------------------------+
| Field                 | Value                                                                    |
+-----------------------+--------------------------------------------------------------------------+
| admin_state_up        | UP                                                                       |
| allowed_address_pairs |                                                                          |
| binding_host_id       | overcloud-rhv-1.localdomain                                              |
| binding_profile       |                                                                          |
| binding_vif_details   | datapath_type='system', ovs_hybrid_plug='True', port_filter='True'       |
| binding_vif_type      | ovs                                                                      |
| binding_vnic_type     | normal                                                                   |
| created_at            | 2018-01-08T14:43:41Z                                                     |
| data_plane_status     | None                                                                     |
| description           |                                                                          |
| device_id             | ab7d9b77-3f4b-4edd-b43d-5a3fa63578ef                                     |
| device_owner          | oVirt                                                                    |
| dns_assignment        | None                                                                     |
| dns_name              | None                                                                     |
| extra_dhcp_opts       |                                                                          |
| fixed_ips             | ip_address='12.0.0.14', subnet_id='b854cabd-4682-4d4e-8f09-e34b8b3200bf' |
| id                    | f4f2a451-45c2-4204-b6f6-682b19cc1894                                     |
| ip_address            | None                                                                     |
| mac_address           | 00:00:00:00:00:21                                                        |
| name                  | nic1                                                                     |
| network_id            | 1194373f-6e53-474e-96bf-581ea5c1617f                                     |
| option_name           | None                                                                     |
| option_value          | None                                                                     |
| port_security_enabled | True                                                                     |
| project_id            | 0446aa0ba1dd4df289c2590ec8a1a382                                         |
| qos_policy_id         | None                                                                     |
| revision_number       | 23                                                                       |
| security_group_ids    | a352570d-f77f-4bb7-95f3-81d6d77e6c6c                                     |
| status                | ACTIVE                                                                   |
| subnet_id             | None                                                                     |
| tags                  |                                                                          |
| trunk_details         | None                                                                     |
| updated_at            | 2018-01-09T13:56:26Z                                                     |
+-----------------------+--------------------------------------------------------------------------+

4. Port state is DOWN, the binding host wasn't changed, but ping still ok-

Port state after migration:

(overcloud) [root@overcloud-controller-0 ~]# openstack port show f4f2a451-45c2-4204-b6f6-682b19cc1894
+-----------------------+--------------------------------------------------------------------------+
| Field                 | Value                                                                    |
+-----------------------+--------------------------------------------------------------------------+
| admin_state_up        | UP                                                                       |
| allowed_address_pairs |                                                                          |
| binding_host_id       | overcloud-rhv-1.localdomain                                              |
| binding_profile       |                                                                          |
| binding_vif_details   | datapath_type='system', ovs_hybrid_plug='True', port_filter='True'       |
| binding_vif_type      | ovs                                                                      |
| binding_vnic_type     | normal                                                                   |
| created_at            | 2018-01-08T14:43:41Z                                                     |
| data_plane_status     | None                                                                     |
| description           |                                                                          |
| device_id             | ab7d9b77-3f4b-4edd-b43d-5a3fa63578ef                                     |
| device_owner          | oVirt                                                                    |
| dns_assignment        | None                                                                     |
| dns_name              | None                                                                     |
| extra_dhcp_opts       |                                                                          |
| fixed_ips             | ip_address='12.0.0.14', subnet_id='b854cabd-4682-4d4e-8f09-e34b8b3200bf' |
| id                    | f4f2a451-45c2-4204-b6f6-682b19cc1894                                     |
| ip_address            | None                                                                     |
| mac_address           | 00:00:00:00:00:21                                                        |
| name                  | nic1                                                                     |
| network_id            | 1194373f-6e53-474e-96bf-581ea5c1617f                                     |
| option_name           | None                                                                     |
| option_value          | None                                                                     |
| port_security_enabled | True                                                                     |
| project_id            | 0446aa0ba1dd4df289c2590ec8a1a382                                         |
| qos_policy_id         | None                                                                     |
| revision_number       | 24                                                                       |
| security_group_ids    | a352570d-f77f-4bb7-95f3-81d6d77e6c6c                                     |
| status                | DOWN                                                                     |
| subnet_id             | None                                                                     |
| tags                  |                                                                          |
| trunk_details         | None                                                                     |
| updated_at            | 2018-01-09T14:36:28Z                                                     |
+-----------------------+--------------------------------------------------------------------------+

Expected results:
Engine should update neutron after VM migrate that the binding host is changed to new host.

Additional info:
See also - https://bugzilla.redhat.com/show_bug.cgi?id=1518370
Comment 1 Michael Burman 2018-01-09 15:02:22 UTC 
Created attachment 1379137 [details]
Logs
Comment 2 Michael Burman 2018-02-27 07:38:21 UTC 
Verified on - 4.2.2.1-0.1.el7 with:
vdsm-4.20.19-1.el7ev.x86_64
Red Hat OpenStack Platform release 12.0 (Pike)
opendaylight-6.2.0-4.el7ost.noarch
Comment 3 Sandro Bonazzola 2018-03-29 11:14:12 UTC 
This bugzilla is included in oVirt 4.2.2 release, published on March 28th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.