Bug 1532683
| Summary: | Virtual Device Role Tagging does not work with interfaces of vnic-type: direct-physical | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Ricardo Noriega <rnoriega> |
| Component: | openstack-nova | Assignee: | Artom Lifshitz <alifshit> |
| Status: | CLOSED ERRATA | QA Contact: | Joe H. Rahme <jhakimra> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 10.0 (Newton) | CC: | alifshit, berrange, dasmith, eglynn, kchamart, lyarwood, sbauza, sgordon, srevivo, vromanso |
| Target Milestone: | z10 | Keywords: | Triaged, ZStream |
| Target Release: | 10.0 (Newton) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-nova-14.1.0-35.el7ost | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-01-16 17:09:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1235009 | ||
|
Description
Ricardo Noriega
2018-01-09 15:18:00 UTC
Sosreports are stored here: https://drive.google.com/drive/folders/1Kmeh0v--UIbSHQwurUMhfk0Kftf3wChZ?usp=sharing Haven't reproduced this at all, but based on just thinking about this and looking at the sosreports, I think this is a real bug.
I believe when we generate the metadata, we match the libvirt NIC (which has information like the MAC and PCI addresses) with its corresponding VirtualInterface nova object (which has information like the device tag) on MAC address, which is the only piece of unique information that both data structures share.
However, PF devices will appear in the libvirt XML as <hostdev> and not <interface>, and more importantly they appear *without* their MAC address:
<hostdev mode="subsystem" type="pci" managed="yes">
<source>
<address bus="0x06" domain="0x0000" function="0x1" slot="0x00"/>
</source>
</hostdev>
Compared to the VIF JSON, in which the MAC appears:
{
"address": "a0:36:9f:ba:04:1e",
[...]
"profile": {
"pci_slot": "0000:06:00.1",
"pci_vendor_info": "8086:1528",
"physical_network": "sriov"
},
[...]
}
I have no ideas as to the fix for now, nor whether it will be backportable to OSP10, given that Newton has been EOLed upstream.
Hey Ricardo, While my patch is waiting for upstream reviews, I've made an OSP10 scratch build [1]. If you want you can play around with it in a test env, to confirm whether it actually fixes the bug or not. I want to be absolutely clear that the build was done with code that is merged absolutely nowhere, and thus comes with no promises whatsoever, except that I did my best to fix the bug. Cheers! [1] https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15149578 Actually, use [2] to download the RPMs, to save you a click from my previous link. [2] https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15149579 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0074 |