Bug 1532720

Summary:	[RFE] Support WebMKS Console in Service UI
Product:	Red Hat CloudForms Management Engine	Reporter:	Kedar Kulkarni <kkulkarn>
Component:	UI - Service	Assignee:	Dávid Halász <dhalasz>
Status:	CLOSED ERRATA	QA Contact:	Sudhir Mallamprabhakara <smallamp>
Severity:	medium	Docs Contact:
Priority:	high
Version:	5.9.0	CC:	awight, dhalasz, greartes, lavenel, obarenbo, simaishi, tuado
Target Milestone:	GA	Keywords:	FutureFeature, RFE
Target Release:	5.11.0	Flags:	kkulkarn: automate_bug+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.0.15	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-12 13:33:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Kedar Kulkarni 2018-01-09 16:28:08 UTC

Description of problem:
In case where the VNC Console is not supported by some VMware versions, in that case we should not disable the VM console button, but we should try to fall back to WebMKS, as either one of those two (VNC and WebMKS) are always supported.

This is being created as a outcome of discussion we had on https://bugzilla.redhat.com/show_bug.cgi?id=1525692

Version-Release number of selected component (if applicable):
5.8.x, 5.9.x

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 5 Allen W 2019-01-29 15:17:36 UTC

Made an issue to track this https://github.com/ManageIQ/manageiq-ui-service/issues/1520

Comment 7 Dávid Halász 2019-07-02 09:47:52 UTC

https://github.com/ManageIQ/manageiq-providers-vmware/pull/409
https://github.com/ManageIQ/manageiq/pull/18927
https://github.com/ManageIQ/manageiq-ui-classic/pull/5761
https://github.com/ManageIQ/manageiq-ui-service/pull/1553

Comment 8 Dávid Halász 2019-07-02 15:21:32 UTC

https://github.com/ManageIQ/manageiq-api/pull/621

Comment 9 Dávid Halász 2019-07-02 15:27:44 UTC

https://github.com/ManageIQ/manageiq-ui-service/pull/1554

Comment 10 CFME Bot 2019-07-02 20:28:25 UTC

New commits detected on ManageIQ/manageiq-providers-vmware/master:

https://github.com/ManageIQ/manageiq-providers-vmware/commit/85acbf7ea22c5b1c91863fa3abc1903be1481caa
commit 85acbf7ea22c5b1c91863fa3abc1903be1481caa
Author:     Dávid Halász <dhalasz>
AuthorDate: Thu Jun 27 05:34:40 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Thu Jun 27 05:34:40 2019 -0400

    Delete code related to the no longer supported MKS remote consoles

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/models/manageiq/providers/vmware/infra_manager.rb | 5 -
 app/models/manageiq/providers/vmware/infra_manager/vm/remote_console.rb | 11 +-
 spec/models/manageiq/providers/vmware/infra_manager/vm/remote_console_spec.rb | 14 -
 3 files changed, 1 insertion(+), 29 deletions(-)


https://github.com/ManageIQ/manageiq-providers-vmware/commit/f2c87c23117eb8d50d8ace52b11641630e12e693
commit f2c87c23117eb8d50d8ace52b11641630e12e693
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 07:38:39 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 07:38:39 2019 -0400

    Create a HTML5 console type on top of VNC and WebMKS

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/models/manageiq/providers/vmware/cloud_manager/vm/remote_console.rb | 5 +
 app/models/manageiq/providers/vmware/infra_manager/vm/remote_console.rb | 10 +-
 spec/models/manageiq/providers/vmware/infra_manager/vm/remote_console_spec.rb | 42 +
 3 files changed, 54 insertions(+), 3 deletions(-)

Comment 11 CFME Bot 2019-07-17 13:10:41 UTC

New commits detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/3c01363e797c1db1095f3991d536185755f8debe
commit 3c01363e797c1db1095f3991d536185755f8debe
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Jun 28 07:21:25 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Jun 28 07:21:25 2019 -0400

    Updated RBAC features and roles for remote consoles

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 db/fixtures/miq_product_features.yml | 16 +-
 db/fixtures/miq_user_roles.yml | 62 +-
 2 files changed, 22 insertions(+), 56 deletions(-)


https://github.com/ManageIQ/manageiq/commit/32ea2e9cc9fc91bafbd3fdd7d745dc2c6d69a748
commit 32ea2e9cc9fc91bafbd3fdd7d745dc2c6d69a748
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 08:23:31 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 08:23:31 2019 -0400

    Drop the global vmware remote console type setting

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/models/vm.rb | 4 -
 app/models/vm/operations.rb | 6 +-
 config/settings.yml | 1 -
 spec/models/vm/operations_spec.rb | 13 +-
 4 files changed, 9 insertions(+), 15 deletions(-)


https://github.com/ManageIQ/manageiq/commit/304063e0967fd38f4c71b8c16201fc9cf9d1e816
commit 304063e0967fd38f4c71b8c16201fc9cf9d1e816
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 15:20:52 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 15:20:52 2019 -0400

    Cleaned up VM operations for launching remote consoles

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/models/mixins/supports_feature_mixin.rb | 8 +-
 app/models/vm.rb | 30 +-
 app/models/vm/operations.rb | 47 +-
 spec/models/vm/operations_spec.rb | 140 +-
 spec/models/vm_spec.rb | 2 +-
 5 files changed, 29 insertions(+), 198 deletions(-)

Comment 12 CFME Bot 2019-07-17 13:13:15 UTC

New commit detected on ManageIQ/manageiq-api/master:

https://github.com/ManageIQ/manageiq-api/commit/94a4aee88af46af128024df9160f09279e6b8640
commit 94a4aee88af46af128024df9160f09279e6b8640
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue Jul  2 11:13:41 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Tue Jul  2 11:13:41 2019 -0400

    Update RBAC features for HTML5 remote consoles

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 config/api.yml | 8 +-
 1 file changed, 4 insertions(+), 4 deletions(-)

Comment 13 CFME Bot 2019-07-17 13:57:21 UTC

New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/e43e9c951e75ad75dfac53bdc7df91bdd7e6f2e1
commit e43e9c951e75ad75dfac53bdc7df91bdd7e6f2e1
Author:     Dávid Halász <dhalasz>
AuthorDate: Fri Jun 28 07:47:39 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Fri Jun 28 07:47:39 2019 -0400

    Reorganize toolbar button classes for better HTML5 console support

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/helpers/application_helper/button/vm_console.rb | 21 -
 app/helpers/application_helper/button/vm_html5_console.rb | 12 +
 app/helpers/application_helper/button/vm_vmrc_console.rb | 4 +-
 app/helpers/application_helper/button/vm_vnc_console.rb | 28 -
 app/helpers/application_helper/button/vm_webmks_console.rb | 35 -
 app/helpers/application_helper/toolbar/cloud/instance_operations_button_group_mixin.rb | 13 +-
 app/helpers/application_helper/toolbar/x_vm_center.rb | 20 +-
 spec/helpers/application_helper/buttons/vm_html5_console_spec.rb | 42 +
 spec/helpers/application_helper/buttons/vm_vnc_console_spec.rb | 53 -
 spec/helpers/application_helper/buttons/vm_webmks_console_spec.rb | 90 -
 spec/support/examples_group/shared_examples_for_vm_console.rb | 38 -
 11 files changed, 64 insertions(+), 292 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/083c3954ce82e08a36a2e135281e19daec1b0afc
commit 083c3954ce82e08a36a2e135281e19daec1b0afc
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 07:38:32 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 07:38:32 2019 -0400

    Have all the HTML5 canvas-based consoles under a single endpoint

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/controllers/vm_remote.rb | 13 +-
 config/routes.rb | 3 -
 spec/routing/vm_infra_routing_spec.rb | 6 -
 3 files changed, 4 insertions(+), 18 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/7324fe0775115eca4280a35941f743a7109cb2ee
commit 7324fe0775115eca4280a35941f743a7109cb2ee
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 08:23:04 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 08:23:04 2019 -0400

    Drop global vmware remote console type setting from the UI

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/controllers/ops_controller/settings/common.rb | 2 -
 app/helpers/vmware_console_helper.rb | 8 -
 app/views/ops/_settings_server_tab.html.haml | 14 -
 spec/helpers/vmware_console_helper_spec.rb | 22 -
 spec/support/examples_group/shared_examples_for_vm_console.rb | 8 -
 5 files changed, 54 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/de80659649dcc0a66853f2b9548ad10cc0b5607c
commit de80659649dcc0a66853f2b9548ad10cc0b5607c
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 13:03:32 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 13:03:32 2019 -0400

    Adjust the WebMKS javascript to handle the nonexisting assets

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 app/assets/javascripts/remote_consoles/webmks.js | 48 +-
 1 file changed, 35 insertions(+), 13 deletions(-)

Comment 14 CFME Bot 2019-07-17 14:11:28 UTC

New commits detected on ManageIQ/manageiq-ui-service/master:

https://github.com/ManageIQ/manageiq-ui-self_service/commit/c8fbe80b35e46d3a5051d63f0fa7e89f3b642999
commit c8fbe80b35e46d3a5051d63f0fa7e89f3b642999
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 15:57:02 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 15:57:02 2019 -0400

    Update the VM remote console button to the new unified HTML5 console

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 client/app/core/product-features.constants.json | 2 +-
 client/app/services/service-details/service-details.component.js | 2 +-
 client/app/services/service-details/service-details.html | 12 +-
 client/app/services/service-explorer/service-explorer.component.spec.js | 2 +-
 client/app/services/services-state.service.js | 2 +-
 client/app/services/services-state.service.spec.js | 2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)


https://github.com/ManageIQ/manageiq-ui-self_service/commit/53005b1bab844805ff05383b1dd40a1f209d17fa
commit 53005b1bab844805ff05383b1dd40a1f209d17fa
Author:     Dávid Halász <dhalasz>
AuthorDate: Mon Jul  1 15:57:02 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Jul  1 15:57:02 2019 -0400

    Update the VM remote console button to the new unified HTML5 console

    https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 client/app/core/product-features.constants.json | 2 +-
 client/app/services/service-details/service-details.component.js | 2 +-
 client/app/services/service-details/service-details.html | 12 +-
 client/app/services/service-explorer/service-explorer.component.spec.js | 2 +-
 client/app/services/services-state.service.js | 2 +-
 client/app/services/services-state.service.spec.js | 2 +-
 6 files changed, 11 insertions(+), 11 deletions(-)


https://github.com/ManageIQ/manageiq-ui-self_service/commit/25517762b8e35fff176c7952c3b8b790263e2ffb
commit 25517762b8e35fff176c7952c3b8b790263e2ffb
Author:     Dávid Halász <dhalasz>
AuthorDate: Tue Jul  2 10:08:44 2019 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Tue Jul  2 10:08:44 2019 -0400

    Add support for WebMKS remote consoles via a custom template

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1532720

 client/app/services/consoles.service.js | 13 +
 client/console/common.ejs | 50 +
 client/console/common.js | 17 +
 client/console/webmks.js | 78 +
 config/webpack.dev.js | 17 +-
 config/webpack.prod.js | 3 +-
 6 files changed, 175 insertions(+), 3 deletions(-)

Comment 15 Antonin Pagac 2019-07-31 13:44:57 UTC

Verified with 5.11.0.17.

Comment 18 errata-xmlrpc 2019-12-12 13:33:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199