Bug 1532873

Summary: Meaningless validation message for live storage migration attempt for disk attached to VM in restoring state
Product: [oVirt] ovirt-engine Reporter: Elad <ebenahar>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.1CC: bugs, tnisan
Target Milestone: ovirt-4.2.1Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-12 11:56:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log
none
Correct engine.log none

Description Elad 2018-01-09 23:25:53 UTC
Created attachment 1379274 [details]
engine.log

Description of problem:
An attempt to live migrate a disk attached to a VM in state restoring is initiated and fails.


Version-Release number of selected component (if applicable):
rhvm-4.2.1-0.2.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. Suspend a VM with disk
2. Restore the VM from suspend and try to move its disk to a different domain

VM restore:

2018-01-10 01:12:52,545+02 INFO  [org.ovirt.engine.core.vdsbroker.CreateVDSCommand] (EE-ManagedThreadFactory-engine-Thread-78260) [ee1831ca-773d-43bb-9e5a-9447478211e4] START, CreateVDSCommand( CreateVDSCommandP
arameters:{hostId='5c2ee991-6583-4dc2-a072-db27aa7615d7', vmId='ca6d1c90-377b-49eb-91f0-bc50f5b0cee0', vm='VM [test1]'}), log id: 69d9c24


Actual results:

Live storage migration is initiated for a VM in restoring state (from suspend):

2018-01-10 01:20:21,261+02 WARN  [org.ovirt.engine.core.bll.storage.lsm.LiveMigrateDiskCommand] (default task-27) [5aad64ca-a6ae-4ffa-96df-c8265c6a76a8] Validation of action 'LiveMigrateDisk' failed for user admin@internal-authz. Reasons: VAR__ACTION__MOVE,VAR__TYPE__DISK
2018-01-10 01:20:21,268+02 INFO  [org.ovirt.engine.core.bll.storage.lsm.LiveMigrateDiskCommand] (default task-27) [5aad64ca-a6ae-4ffa-96df-c8265c6a76a8] Lock freed to object 'EngineLock:{exclusiveLocks='[ca6d1c90-377b-49eb-91f0-bc50f5b0cee0=LIVE_STORAGE_MIGRATION]', sharedLocks=''}'
2018-01-10 01:20:21,295+02 INFO  [org.ovirt.engine.core.bll.storage.disk.MoveDiskCommand] (default task-27) [5aad64ca-a6ae-4ffa-96df-c8265c6a76a8] Lock freed to object 'EngineLock:{exclusiveLocks='[580ae51c-d3cb-46c0-8d99-af58205d3825=DISK]', sharedLocks=''}'

Expected results:
Live storage migration should be blocked for VM in restoring state

Additional info:
engine.log

Comment 1 Elad 2018-01-09 23:28:08 UTC
Created attachment 1379275 [details]
Correct engine.log

Correct engine.log

Comment 2 Tal Nisan 2018-01-10 16:24:04 UTC
The validation here do fail but without any message so it's very not helpful for the user, I'll add a proper validation message

Comment 3 Tal Nisan 2018-01-14 12:09:24 UTC
*** Bug 1534205 has been marked as a duplicate of this bug. ***

Comment 4 Elad 2018-01-21 16:07:12 UTC
A proper validation message for live storage migration attempt for disk attached to VM in restoring state.

Error while executing action: Cannot move Virtual Disk. The operation is not supported for MEMORY_METADATA_VOLUME disks.


Used:
rhvm-4.2.1.2-0.1.el7.noarch

Comment 5 Sandro Bonazzola 2018-02-12 11:56:19 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.