Bug 1533000

Summary:	Quota crawl regressed
Product:	[Community] GlusterFS	Reporter:	Sanoj Unnikrishnan <sunnikri>
Component:	quota	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Vinayak Papnoi <vpapnoi>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-23 15:06:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1581231

Description Sanoj Unnikrishnan 2018-01-10 08:55:25 UTC

Description of problem: Quota crawling is regressed

How reproducible: always

Steps to Reproduce:
1. create a FS with with multiple files(of reasonable size ), say at a hierarchy depth of 5.
2. enable quota and wait for quota crawl to finish.
3. do a quota list / to check if the files sizes are accounted.
4. verify the quota xattrs are set for the files in depth 5 at the backend

Actual results:
xattr where not set at back end and hence the files were unaccounted at root until a subsequent lookup.

Expected results:
the xattr should be populated at back end and the correct size must be reported.

The code was Regressed from this commit
https://review.gluster.org/#/c/12952/

Doing a find . on the mount does not result in a lookup on all the files.
for a lookup to happen we should do "find . -exect stat {} \;"

Comment 1 Worker Ant 2018-05-22 12:20:15 UTC

REVIEW: https://review.gluster.org/20057 (Quota: Fix crawling of files) posted (#1) for review on master by sanoj-unnikrishnan

Comment 2 Worker Ant 2018-07-13 07:35:23 UTC

COMMIT: https://review.gluster.org/20057 committed in master by "Amar Tumballi" <amarts> with a commit message- Quota: Fix crawling of files

Problem: Running "find ." does not crawl files. It goes over the
directories and lists all dentries with getdents system call.
Hence the files are not looked up.

Solution:
explicitly triggerr stat on files with find . -exec stat {} \;
since crawl can take slightly longer, updating timeout in test case

Change-Id: If3c1fba2ed8e300c9cc08c1b5c1ba93cb8e4d6b6
fixes: bz#1533000
Signed-off-by: Sanoj Unnikrishnan <sunnikri>

Comment 4 Shyamsundar 2018-10-23 15:06:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/