Bug 1533217

Summary:	Quota fails when an active Service request contains an Invalid service_template.
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Anurag <ansinha>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	5.8.0	CC:	akarol, cpelland, jocarter, mkanoor, obarenbo, rovalent, saali, smallamp, tfitzger
Target Milestone:	GA
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.17	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1531914	Environment:
Last Closed:	2018-03-06 15:29:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1531914
Bug Blocks:

Comment 2 CFME Bot 2018-01-10 18:51:47 UTC

New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/9b58a4a4dc2a0bc90849c432584e0a22b2d07513

commit 9b58a4a4dc2a0bc90849c432584e0a22b2d07513
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jan 9 15:30:37 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Jan 10 13:46:10 2018 -0500

    Merge pull request #16769 from tinaafitz/quota_mixin_service_template_fix
    
    Fix check_quota(:active_provisions) for Service MiqRequest invalid service_template.
    (cherry picked from commit 8aa881f53bfa3ae2517921bbd061d82d01ccd600)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533217

 app/models/mixins/miq_provision_quota_mixin.rb               | 1 +
 spec/models/service_template_provision_request_quota_spec.rb | 6 ++++++
 2 files changed, 7 insertions(+)

Comment 3 Anurag 2018-02-08 09:37:19 UTC

Hi Tina,

I have verified this issue and it's working fine. To verify this bug I followed steps mentioned in comments of the BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1534589. Hence changing the status from ON_QA to Verified. Thanks for fixing this issue.

Thanks,
-Anurag

Comment 4 Anurag 2018-02-08 10:15:18 UTC

Verified on version: Version 5.9.0.20.20180206200727_d1873b9