Bug 1533499

Summary: [RHEV provider][vm provision] Specifying vnic profile on virtual nic instead of network.
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: ProvidersAssignee: Alona Kaplan <alkaplan>
Status: CLOSED ERRATA QA Contact: Jan Zmeskal <jzmeskal>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: alkaplan, danken, gblomqui, jfrey, jhardy, jzmeskal, masayag, mburman, obarenbo, simaishi
Target Milestone: GA   
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: rhev
Fixed In Version: 5.9.0.17 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1449157 Environment:
Last Closed: 2018-03-01 13:23:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: RHEVM Target Upstream Version:
Embargoed:
Bug Depends On: 1449157    
Bug Blocks:    

Comment 2 CFME Bot 2018-01-11 14:17:01 UTC
New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/af1170b93c9e174def52c8c9fb7b8f39b2a1a890

commit af1170b93c9e174def52c8c9fb7b8f39b2a1a890
Author:     Greg McCullough <gmccullo>
AuthorDate: Wed Jan 10 13:32:52 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jan 11 09:13:18 2018 -0500

    Merge pull request #16504 from AlonaKaplan/master
    
    Adding the option to set default vlan
    (cherry picked from commit 30631c2f1a8d9bcd964b8fa85a1870f8fa07993e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1533499

 app/models/miq_provision_virt_workflow.rb                              | 1 +
 .../dialogs/miq_dialogs/miq_provision_redhat_dialogs_clone_to_vm.yaml  | 3 ++-
 product/dialogs/miq_dialogs/miq_provision_redhat_dialogs_template.yaml | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

Comment 3 CFME Bot 2018-01-11 14:39:21 UTC
New commit detected on ManageIQ/manageiq-providers-ovirt/gaprindashvili:
https://github.com/ManageIQ/manageiq-providers-ovirt/commit/d9c5dede30e2c23c60cef121bd72489bae0f6f64

commit d9c5dede30e2c23c60cef121bd72489bae0f6f64
Author:     Moti Asayag <masayag>
AuthorDate: Thu Jan 11 10:00:31 2018 +0200
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Jan 11 09:34:40 2018 -0500

    Merge pull request #150 from AlonaKaplan/profiles
    
    Set '<Use template nics>' as the default vnic profile option
    (cherry picked from commit 94dc3477e941f15570f6b01126689f0747b0895e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533499

 .../providers/redhat/infra_manager/ovirt_services/strategies/v4.rb  | 1 +
 .../redhat/infra_manager/provision/configuration/network.rb         | 2 +-
 .../providers/redhat/infra_manager/provision_workflow_spec.rb       | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)

Comment 4 Jan Zmeskal 2018-02-02 12:13:09 UTC
I verified that provisioning works as expected when done via CFME UI. I tested all three scenarios (template's default vNIC profile, no vNIC profile, explicitely specified profile) and all worked fine. 

However, I cannot verify REST provision unless BZ1541036 is fixed.

Comment 5 Jan Zmeskal 2018-02-07 11:05:09 UTC
So the description of BZ1541036 and its purpose have changed. The REST API is not broken, it was just changed. 

I verified provisioning requests via REST API on CFME 5.9.0.20 using this POST:
{"additional_values": {"request_id": "1001"},
 "ems_custom_attributes": {},
 "miq_custom_attributes": {},
 "requester": {"auto_approve": true,
  "owner_email": "jdoe",
  "owner_first_name": "John",
  "owner_last_name": "Doe",
  "user_name": "admin"},
 "tags": {"cc": "001", "network_location": "Internal"},
 "template_fields": {"guid": "<template_guid>"},
 "version": "1.1",
 "vm_fields": {"number_of_cpus": 1,
  "provision_type": "native_clone",
  "vlan": "<vnic_profile_id>",
  "vm_memory": "2048",
  "vm_name": "<vm_name>"}}

I also tested three scenarios as they are described in here:
https://bugzilla.redhat.com/show_bug.cgi?id=1541036#c4 
1) "vlan": "3a8dce01-dd59-4a46-8a6f-823acccda79f" (specific template ID)
2) "vlan": <Empty> (no vNIC profile)
3) "vlan": <Template> (use template's default vNIC profile)
All of them worked as expected.

Comment 8 errata-xmlrpc 2018-03-01 13:23:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380