Bug 1534171

Summary: Review Request: mumble - Voice chat suite aimed at gamers
Product: [Fedora] Fedora EPEL Reporter: Marcel Telka <marcel>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: epel7CC: carlwgeorge, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-12-05 15:45:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841    

Description Marcel Telka 2018-01-13 18:29:40 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/mzprx/mumble-epel/epel-7-x86_64/00696120-mumble/mumble.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mzprx/mumble-epel/epel-7-x86_64/00696120-mumble/mumble-1.2.19-4.el7.centos.src.rpm
Description:
Mumble is a voip client server package.  I'm trying to add it to EPEL together with the celt071 package.  This package is rebuild of recent mumble package from Fedora with some minor tweaks to make it buildable on el7.

Fedora Account System Username: mzprx
Comment 1 Michael Schwendt 2018-01-25 11:59:22 UTC 
This is an unusual request for various reasons. 

You're asking for a re-review of a package included in the package collection. Especially since you've not added a %changelog comment about your "minor tweaks".

  https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs


A much better approach would be to contact the existing Fedora packagers and then choose one of the steps mentioned at:

  https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Become_a_co-maintainer


> #Due to naming issues, celt071 is required explicitly
> Requires:       celt071

Note that "naming issues" might not suffice. More likely, the real reason is a missing automatic dependency on the libcelt SONAME, because the package does this:

lrwxrwxrwx    1 root    root                       22 Aug  4 05:16 /usr/lib64/mumble/libcelt.so.0.7.0 -> ../libcelt071.so.0.0.0

As such, an explicit dependency on "celt071" is too weak. You want it to be arch-specific as in:
  https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
Comment 2 Carl George 🤠 2018-12-05 15:45:57 UTC 
As noted, this needs to be accomplished by adding an epel7 branch to the existing mumble package.