Bug 1534205

Summary: Meaningless validation message for stateless VM disk LSM attempt
Product: [oVirt] ovirt-engine Reporter: Elad <ebenahar>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED DUPLICATE QA Contact: Raz Tamir <ratamir>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.1CC: bugs, tnisan
Target Milestone: ovirt-4.2.1Flags: rule-engine: ovirt-4.2?
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-14 12:09:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Elad 2018-01-14 07:14:18 UTC
Created attachment 1380897 [details]
engine.log

Description of problem:
When trying to move a disk of a running stateless VM, the validation message of the failure is empty.

Version-Release number of selected component (if applicable):
rhvm-4.2.1-0.2.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create and start a stateless VM with disk attached
2. Try to move the stateless VM disk while the VM is running



Actual results:
The operation fails as expected but the validation message is meaningless: 

2018-01-14 09:07:53,396+02 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engineScheduled-Thread-13) [] EVENT_ID: VDS_INITIATED_RUN_VM_AS_STATELESS(537), VM test was restarted on Host host_mixed_1 as stateless


Expected results:
A meaningful validation message

Additional info:
engine.log

Comment 1 Elad 2018-01-14 07:19:06 UTC
The empty validation message for stateless VM disk live storage migration attempt:

2018-01-14 09:07:48,186+02 WARN  [org.ovirt.engine.core.bll.storage.lsm.LiveMigrateDiskCommand] (default task-12) [558ad827-6484-47e1-8c28-6be86bfd8040] Validation of action 'LiveMigrateDisk' failed for user admin@internal-authz. Reasons: VAR__ACTION__MOVE,VAR__TYPE__DISK

Comment 2 Tal Nisan 2018-01-14 10:36:07 UTC
Following your steps to reproduce I got "Cannot create Snapshot. The VM is running as Stateless. Please try again when VM is not running as Stateless."
Something might be missing in the scenario?

Comment 3 Elad 2018-01-14 11:12:53 UTC
I manage to reproduce it every time, just try to live migrate a stateless VM disk.

2018-01-14 13:11:33,192+02 WARN  [org.ovirt.engine.core.bll.storage.lsm.LiveMigrateDiskCommand] (default task-5) [eac1800c-bb16-4891-a14a-58a94de35631] Validation of action 'LiveMigrateDisk' failed for user admin@internal-authz. Reasons: VAR__ACTION__MOVE,VAR__TYPE__DISK

Comment 4 Tal Nisan 2018-01-14 12:09:24 UTC
OK, I've tried on your environment, you have the same expected error that I got while the VM is up but while it's not up you get another error regarding the state of the VM which is actually a dup of bug 1532873 (since the VM is not in Up or Paused status).

*** This bug has been marked as a duplicate of bug 1532873 ***