Bug 1534231

Summary: 'stateless snapshot' disk snapshot is removable
Product: [oVirt] ovirt-engine Reporter: Elad <ebenahar>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.1CC: bugs, lveyde, tnisan
Target Milestone: ovirt-4.2.1Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.2.1.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-12 11:55:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine and vdsm logs none

Description Elad 2018-01-14 12:11:03 UTC
Created attachment 1380983 [details]
engine and vdsm logs

Description of problem:
A stateless VM's disk snapshot is wrongly removable if it's being removed from storage domain's disk snapshot. 

Version-Release number of selected component (if applicable):
rhvm-4.2.1-0.2.el7.noarch
vdsm-4.20.11-1.el7ev.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Create a stateless VM with a disk attached
2. Start the VM
3. Navigate to storage domains -> the domain where the VM disk resides -> Disk snapshots
4. Try to remove the disk snapshot called 'stateless snapshot'


Actual results:
'stateless snapshot' disk snapshot is removable

Expected results:
'stateless snapshot' disk snapshot should not be removable


Additional info:


2018-01-14 14:01:47,443+02 INFO  [org.ovirt.engine.core.bll.snapshots.RemoveSnapshotSingleDiskLiveCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-16) [910da3cf-02cb-4c61-8fc0-5225925d3ca3] Successfully 
merged snapshot '12a881c0-1836-4f23-a093-6bf95765b18c' images '74b17f54-7f15-42dd-ad89-2ea8b69d1570'..'2fc387b5-be9b-4744-9ca6-aba9dfd95303'
2018-01-14 14:01:47,463+02 INFO  [org.ovirt.engine.core.bll.snapshots.RemoveSnapshotSingleDiskLiveCommand] (EE-ManagedThreadFactory-engineScheduled-Thread-16) [910da3cf-02cb-4c61-8fc0-5225925d3ca3] Ending comman
d 'org.ovirt.engine.core.bll.snapshots.RemoveSnapshotSingleDiskLiveCommand' successfully.
2018-01-14 14:01:48,490+02 INFO  [org.ovirt.engine.core.bll.SerialChildCommandsExecutionCallback] (EE-ManagedThreadFactory-engineScheduled-Thread-36) [910da3cf-02cb-4c61-8fc0-5225925d3ca3] Command 'RemoveDiskSna
pshots' id: '9648472d-4abd-425b-b9e2-9f286bc72457' child commands '[b0214935-a9b7-4e72-9554-0f01a41924bd]' executions were completed, status 'SUCCEEDED'

Comment 1 Elad 2018-01-29 11:16:08 UTC
An attempt to remove the stateless_snapshot disk snapshot is blocked properly:


2018-01-29 13:13:34,047+02 WARN  [org.ovirt.engine.core.bll.snapshots.RemoveDiskSnapshotsCommand] (default task-2) [6213a0ed-232d-4a4d-91b4-0b85a45dbe74] Validation of action 'RemoveDiskSnapshots' failed for user admin@internal-authz. Reasons: VAR__ACTION__REMOVE,VAR__TYPE__DISK__SNAPSHOT,ACTION_TYPE_FAILED_VM_SNAPSHOT_TYPE_NOT_REGULAR


Used:
rhvm-4.2.1.3-0.1.el7.noarch

Comment 2 Sandro Bonazzola 2018-02-12 11:55:55 UTC
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.