Bug 1534457

Summary: Error updating Nuage provider
Product: Red Hat CloudForms Management Engine Reporter: mplesko
Component: ProvidersAssignee: Gregor Berginc <gregor.berginc>
Status: ON_QA --- QA Contact: Gregor Berginc <gregor.berginc>
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: cpelland, gblomqui, jhardy, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1552895 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1552895    
Attachments:
Description Flags
Error page after I press Save none

Description mplesko 2018-01-15 09:58:46 UTC
Created attachment 1381331 [details]
Error page after I press Save

Description of problem:
Browser shows error page after editing existing Nuage provider.


Version-Release number of selected component (if applicable):


How reproducible:
Always


Steps to Reproduce:
1. Open provider, then pick "Edit this Network Provider" from the mid-page menu
2. Update some value
3. Click Save

Actual results:
Error page appears saying "The page you were looking for doesn't exist." (see screenshot attached)

Expected results:
Provider page is opened.

Additional info:

Comment 2 Dave Johnson 2018-01-15 10:04:03 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 5 CFME Bot 2018-02-09 22:59:17 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/c525ab7933f6f427073c393e6278e69307aaf50f

commit c525ab7933f6f427073c393e6278e69307aaf50f
Author:     sasoc <saso.cvitkovic>
AuthorDate: Tue Jan 30 11:03:10 2018 +0100
Commit:     sasoc <saso.cvitkovic>
CommitDate: Tue Feb 6 11:41:12 2018 +0100

    Fix Nuage provider update
    
    There were two problems when editing Nuage network provider. If
    network that you edited had no event, there would still be AMQP
    selected under the Events tab. That made Save button disabled
    since hostname must not be empty and everything has to be verified.
    Now None is selected in case of no event.
    The second problem was that when a network was updated error occurred
    while redirecting, since you would only get one argument and
    `ems_path` required two. Now `ems_path` works same as
    in the cloud provider controller.
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534457

 app/controllers/ems_network_controller.rb          |  3 +-
 app/controllers/mixins/ems_common_angular.rb       |  5 +-
 spec/controllers/mixins/ems_common_angular_spec.rb | 57 ++++++++++++++++++++++
 3 files changed, 61 insertions(+), 4 deletions(-)
 create mode 100644 spec/controllers/mixins/ems_common_angular_spec.rb