Bug 1534529
| Summary: | GenericObject: Can't add existing custom button in existing button group of GenericObject | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Yadnyawalk Tale <ytale> | ||||||||
| Component: | UI - OPS | Assignee: | Zita Nemeckova <znemecko> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Yadnyawalk Tale <ytale> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 5.9.0 | CC: | akarve, cpelland, dmetzger, hkataria, jocarter, lavenel, mhradil, mpovolny, nansari, obarenbo, simaishi | ||||||||
| Target Milestone: | GA | Flags: | ytale:
automate_bug-
|
||||||||
| Target Release: | 5.11.0 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | custom_button:button:generic_object | ||||||||||
| Fixed In Version: | 5.11.0.18 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2019-12-12 13:33:48 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | Bug | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 1383445 [details]
the missing part of the form
*** Bug 1650569 has been marked as a duplicate of this bug. *** New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/831bda58fca04e73819a3f0953702de64365e8be commit 831bda58fca04e73819a3f0953702de64365e8be Author: Zita Nemeckova <znemecko> AuthorDate: Wed Nov 14 07:54:51 2018 -0500 Commit: Zita Nemeckova <znemecko> CommitDate: Wed Nov 14 07:54:51 2018 -0500 Add assign button section to Custom Button Group in GOD - created assign_button component - added that component to main-custom-button-group-form component - make it work together Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534529 app/assets/javascripts/components/generic_object/assign-buttons.js | 153 + app/assets/javascripts/components/generic_object/main-custom-button-group-form.js | 59 +- app/controllers/generic_object_definition_controller.rb | 23 + app/views/static/generic_object/assign-buttons.html.haml | 57 + app/views/static/generic_object/main_custom_button_group_form.html.haml | 3 + config/routes.rb | 2 + 6 files changed, 281 insertions(+), 16 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/9ed0f565ff438a2c9b2a549a680fb28bc0cf8a55 commit 9ed0f565ff438a2c9b2a549a680fb28bc0cf8a55 Author: Martin Hradil <mhradil> AuthorDate: Fri Aug 2 07:04:13 2019 -0400 Commit: Martin Hradil <mhradil> CommitDate: Fri Aug 2 07:04:13 2019 -0400 Merge pull request #4913 from ZitaNemeckova/god_buttons GOD's button group can have buttons assign/unassign during create/edit (cherry picked from commit 1fc6e6197f273a4719af75817f0e0a6be8f627f1) https://bugzilla.redhat.com/show_bug.cgi?id=1534529 app/assets/javascripts/components/generic_object/assign-buttons.js | 59 + app/assets/javascripts/components/generic_object/main-custom-button-group-form.js | 62 +- app/assets/javascripts/directives/form_changed.js | 2 +- app/assets/javascripts/miq_global.js | 2 + app/controllers/generic_object_definition_controller.rb | 15 + app/javascript/helpers/move.js | 109 + app/javascript/packs/application-common.js | 3 + app/views/static/generic_object/assign-buttons.html.haml | 55 + app/views/static/generic_object/main_custom_button_group_form.html.haml | 3 + config/routes.rb | 1 + spec/javascripts/components/generic_object_definition/assign-buttons_spec.js | 156 + 11 files changed, 448 insertions(+), 19 deletions(-) Created attachment 1601871 [details]
fixed.png
Fixed! Verified in 5.11.0.18.20190806180636_1dd6378. Thanks! :)
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199 |
Created attachment 1381409 [details] Issue_GIF Description of problem: Issue is about custom buttons in generic object. Can't add existing custom button in existing button group of GenericObject Version-Release number of selected component (if applicable): 5.9.0.16.20180109204148_7ac9852 How reproducible: 100% Steps to Reproduce: 1. Navigate to Automation > Automate > Generic Object 2. Add Generic Object Class 3. In this class, add custom button 4. In same class, add new custom button group 5. Try to add that button in that group Actual results: Not able to add custom button to existing group Expected results: Should add existing custom button to group. (Custom group should have `Assign Buttons` selected/unselected box) Additional info: