Bug 1535207 (perl(Ravada))

So we finally have all needed dependencies as official packages? That's awesome.

I could look into this request later. Thanks for your great work.

FYI requested support in qt-virt-viewer:
https://github.com/F1ash/qt-virt-manager/issues/29

(In reply to Raphael Groner from comment #1)
> So we finally have all needed dependencies as official packages? That's
> awesome.
> 
> I could look into this request later. Thanks for your great work.

Do you plan on reviewing it soon?

Thanks for the reminder and sorry for the delay. I hoped we can wait for a new release from upstream including latest (important) fixes. Maybe you want to package a pre-release or shapshot?


*No copyright* Apache (v2.0)
----------------------------
ravada-0.2.12/public/css/sb-admin.css
ravada-0.2.12/public/js/main.js

Add ASL 2.0 to License tag with a breakdown for above files in a comment, they're obviously taken from startbootstrap.com templates.


Rpmlint
-------
Checking: ravada-0.2.12-1.fc28.noarch.rpm
          ravada-0.2.12-1.fc28.src.rpm
ravada.noarch: E: explicit-lib-dependency libvirt-daemon-kvm
ravada.noarch: E: explicit-lib-dependency libvirt-daemon-lxc
=> Maybe remove.
ravada.noarch: E: zero-length /usr/share/ravada/public/css/custom/insert_here_custom_css
ravada.noarch: E: zero-length /usr/share/ravada/public/img/custom/insert_here_custom_images
ravada.noarch: E: zero-length /usr/share/ravada/public/js/custom/insert_here_custom_javascripts
ravada.noarch: E: zero-length /usr/share/ravada/templates/main/custom/insert_here_custom_template
=> Remove.
ravada.noarch: W: no-manual-page-for-binary rvd_back.pl
ravada.noarch: W: no-manual-page-for-binary rvd_front.pl
ravada.src: W: file-size-mismatch ravada-0.2.12.tar.gz = 1333333, https://github.com/UPC/ravada/archive/0.2.12/ravada-0.2.12.tar.gz = 1333228
2 packages and 0 specfiles checked; 6 errors, 3 warnings.


Source checksums
----------------
https://github.com/UPC/ravada/archive/0.2.12/ravada-0.2.12.tar.gz :
  CHECKSUM(SHA256) this package     : 621523e70abecc028f2985f63131e73a7fd3af64b7c68920b50979576fb5338d
  CHECKSUM(SHA256) upstream package : f7a91597a5f11374743daaa87d00314ecb015c9a2d7297200569beb07107b8d3
diff -r also reports differences

diff -U2 -r /home/builder/fedora-review/1535207-ravada/upstream-unpacked/Source0/ravada-0.2.12/lib/Ravada.pm /home/builder/fedora-review/1535207-ravada/srpm-unpacked/ravada-0.2.12.tar.gz-extract/ravada-0.2.12/lib/Ravada.pm
--- /home/builder/fedora-review/1535207-ravada/upstream-unpacked/Source0/ravada-0.2.12/lib/Ravada.pm    2018-01-22 10:02:48.000000000 +0100
+++ /home/builder/fedora-review/1535207-ravada/srpm-unpacked/ravada-0.2.12.tar.gz-extract/ravada-0.2.12/lib/Ravada.pm   2018-01-16 15:48:42.000000000 +0100
@@ -4,5 +4,5 @@
 use strict;
 
-our $VERSION = '0.2.12';
+our $VERSION = '0.2.12-rc1';
 
 use Carp qw(carp croak);


All other look good so far.

Updated with your recommendations:

Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/25245d1/ravada.spec
SRPM url: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00710890-ravada/ravada-0.2.13-0.1.20180117gitf70dfbf.fc28.src.rpm

SPEC diff: https://github.com/eclipseo/packaging/commit/25245d1b5ba77fe0a7ce6a3cc71d2885e36cb648#diff-17e2f419b7ab9101f056c0f5d38fe283

I fixed the buildroot/RPM_BUILD_ROOT issue mentionned py fedora-review after this, I don't want to rebuild it for such a minor change.

(In reply to Robert-André Mauchin from comment #6)
> I fixed the buildroot/RPM_BUILD_ROOT issue mentionned py fedora-review after
> this, I don't want to rebuild it for such a minor change.

Not fixed. Can you upload and show fixed SPEC and SRPM files?

Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/cea62fb/ravada.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00711120-ravada/ravada-0.2.13-0.1.20180117gitf70dfbf.fc28.src.rpm

APPROVED

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "AGPL (v3)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 280 files have unknown license. Detailed output of
     licensecheck in /home/builder/fedora-
     review/1535207-ravada/licensecheck.txt
=> License breakdown available.

[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 81920 bytes in 50 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.

===== SHOULD items =====

Generic:
[?]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
=> No idea what this means. Maybe due to bundled templates.

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
=> OK. Some tests do not run, it's recommended to disable them.

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ravada-0.2.13-0.1.20180117gitf70dfbf.fc28.noarch.rpm
          ravada-0.2.13-0.1.20180117gitf70dfbf.fc28.src.rpm
ravada.noarch: W: no-manual-page-for-binary rvd_back.pl
ravada.noarch: W: no-manual-page-for-binary rvd_front.pl
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
ravada.noarch: W: invalid-url URL: https://ravada.upc.edu/ <urlopen error [Errno -2] Name or service not known>
ravada.noarch: W: no-manual-page-for-binary rvd_back.pl
ravada.noarch: W: no-manual-page-for-binary rvd_front.pl
1 packages and 0 specfiles checked; 0 errors, 3 warnings.



Requires
--------
ravada (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    /usr/bin/perl
    config(ravada)
    iptables
    libvirt
    mariadb-common
    perl(:MODULE_COMPAT_5.26.1)
    perl(Authen::Passphrase)
    perl(Authen::Passphrase::SaltedDigest)
    perl(Carp)
    perl(DBIx::Connector)
    perl(Data::Dumper)
    perl(Digest::MD5)
    perl(Digest::SHA)
    perl(Encode)
    perl(Encode::Locale)
    perl(Fcntl)
    perl(File::Basename)
    perl(File::Copy)
    perl(File::Path)
    perl(File::Temp)
    perl(Getopt::Long)
    perl(Hash::Util)
    perl(IO::Interface)
    perl(IO::Interface::Simple)
    perl(IO::Socket)
    perl(IPC::Run3)
    perl(IPTables::ChainMgr)
    perl(Image::Magick)
    perl(JSON::XS)
    perl(LWP::UserAgent)
    perl(Locale::Maketext)
    perl(Locale::Maketext::Lexicon)
    perl(Mojo::DOM)
    perl(Mojo::Home)
    perl(Mojo::UserAgent)
    perl(Mojolicious::Lite)
    perl(Moose)
    perl(Moose::Role)
    perl(Moose::Util::TypeConstraints)
    perl(MooseX::Types::NetAddr::IP)
    perl(Net::DNS)
    perl(Net::Domain)
    perl(Net::LDAP)
    perl(Net::LDAP::Entry)
    perl(Net::LDAP::Util)
    perl(Net::LDAPS)
    perl(NetAddr::IP)
    perl(POSIX)
    perl(Proc::PID::File)
    perl(Ravada)
    perl(Ravada::Auth)
    perl(Ravada::Auth::LDAP)
    perl(Ravada::Auth::SQL)
    perl(Ravada::Domain::Driver)
    perl(Ravada::Domain::KVM)
    perl(Ravada::Domain::LXC)
    perl(Ravada::Domain::Void)
    perl(Ravada::Front)
    perl(Ravada::NetInterface::KVM)
    perl(Ravada::NetInterface::MacVTap)
    perl(Ravada::NetInterface::Void)
    perl(Ravada::Network)
    perl(Ravada::Request)
    perl(Ravada::Utils)
    perl(Ravada::VM::Void)
    perl(Socket)
    perl(Sys::Hostname)
    perl(Sys::Statistics::Linux)
    perl(Sys::Virt)
    perl(Sys::Virt::Stream)
    perl(URI)
    perl(XML::LibXML)
    perl(YAML)
    perl(base)
    perl(feature)
    perl(lib)
    perl(locale)
    perl(strict)
    perl(vars)
    perl(warnings)
    qemu-img
    shadow-utils
    systemd



Provides
--------
ravada:
    config(ravada)
    perl(Ravada)
    perl(Ravada::Auth)
    perl(Ravada::Auth::LDAP)
    perl(Ravada::Auth::SQL)
    perl(Ravada::Auth::User)
    perl(Ravada::Domain)
    perl(Ravada::Domain::Driver)
    perl(Ravada::Domain::KVM)
    perl(Ravada::Domain::LXC)
    perl(Ravada::Domain::Void)
    perl(Ravada::Front)
    perl(Ravada::I18N)
    perl(Ravada::NetInterface)
    perl(Ravada::NetInterface::KVM)
    perl(Ravada::NetInterface::MacVTap)
    perl(Ravada::NetInterface::Void)
    perl(Ravada::Network)
    perl(Ravada::Request)
    perl(Ravada::Utils)
    perl(Ravada::VM)
    perl(Ravada::VM::KVM)
    perl(Ravada::VM::LXC)
    perl(Ravada::VM::Void)
    ravada



Source checksums
----------------
https://github.com/UPC/ravada/archive/0.2.13/ravada-0.2.13.tar.gz :
  CHECKSUM(SHA256) this package     : ce4a66133a99bb418da5419fde6742868dfc4468f0f7475b7e6734d2bebacfa4
  CHECKSUM(SHA256) upstream package : ce4a66133a99bb418da5419fde6742868dfc4468f0f7475b7e6734d2bebacfa4


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1535207
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Perl
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ravada. You may commit to the branch "f27" in about 10 minutes.

ravada-0.2.13-0.1.20180117gitf70dfbf.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ff2ff1802

ravada-0.2.13-0.1.20180117gitf70dfbf.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ff2ff1802

ravada-0.2.13-0.1.20180117gitf70dfbf.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b84388d863

ravada-0.2.13-0.1.20180117gitf70dfbf.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

ravada-0.2.13-0.1.20180117gitf70dfbf.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

ravada-0.2.14-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-8109ac4a9b

ravada-0.2.14-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-8109ac4a9b

ravada-0.2.14-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.