Bug 1535231

Summary: [RFE] Make Automation State Machine Log Lines Uniform
Product: Red Hat CloudForms Management Engine Reporter: myoder
Component: AutomateAssignee: Patrik Kománek <pkomanek>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: dmisharo, hkataria, lavenel, mfeifer, mkanoor, mpovolny, obarenbo, simaishi, tfitzger
Target Milestone: MVPKeywords: FutureFeature, TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1552282 (view as bug list) Environment:
Last Closed: 2019-02-11 14:06:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1552282, 1555371    

Description myoder 2018-01-16 21:55:55 UTC
Description of problem:

In the following service provision [1], there are log lines with the syntax "State=" that are not consistent.  It seems the log lines with "Processed" include an extra space before the word 'State', and once between the word 'State' and '='.


[1]
[----] I, [2017-11-20T10:22:08.148416 #29889:1063140]  INFO -- : In State=[StartRetirement], invoking [on_entry] method=[update_retirement_status(status => 'Starting Retirement')]
[----] I, [2017-11-20T10:22:26.597643 #29889:1063140]  INFO -- : Processing State=[StartRetirement]
[----] I, [2017-11-20T10:22:55.636330 #29889:1063140]  INFO -- : Processed  State=[StartRetirement] with Result=[ok]
[----] I, [2017-11-20T10:22:55.636402 #29889:1063140]  INFO -- : Processed State =[StartRetirement]
[----] I, [2017-11-20T10:22:55.636519 #29889:1063140]  INFO -- : In State=[StartRetirement], invoking [on_exit] method=[update_retirement_status(status => 'Started Retirement')]


Version-Release number of selected component (if applicable):
all versions

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
In State=[StartRetirement]
Processing State=[StartRetirement]                    
Processed  State=[StartRetirement] with Results=[ok]  <===== Has extra space
Processed State =[StartRetirement]                    <===== Has extra space
In State=[StartRetirement]

Expected results:
In State=[StartRetirement]
Processing State=[StartRetirement]
Processed State=[StartRetirement] with Results=[ok]
Processed State=[StartRetirement]
In State=[StartRetirement]

Additional info:

Comment 2 Greg McCullough 2018-01-17 15:49:30 UTC
Patrik - Let's follow the "Expected results" alignment in the BZ description.

Comment 3 Patrik Kománek 2018-01-29 11:55:21 UTC
solved in https://github.com/ManageIQ/manageiq-automation_engine/pull/152

Comment 5 Dmitry Misharov 2018-06-22 11:22:02 UTC
Fixed and verified in 5.10.0.1.20180619163011_900fdc4.