Bug 1535422

Summary: redhat-rpm-config: Link with -Wl,-z,defs to get errors for undefined symbols
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: redhat-rpm-configAssignee: Florian Weimer <fweimer>
Status: CLOSED CANTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ajax, dzickus, ffesti, fweimer, igor.raits, john.j5live, jonathan, nickc, pmatilai, praiskup, rjones, sgehwolf
Target Milestone: ---Keywords: FutureFeature, Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: redhat-rpm-config-84-1.fc28 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-09 09:40:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1525568    
Bug Blocks: 1531540    
Attachments:
Description Flags
Pass -z defs to the linker none

Description Florian Weimer 2018-01-17 11:02:50 UTC 
Created attachment 1382350 [details]
Pass -z defs to the linker

Undefined symbols are unversioned and are not bound to the correct symbol version at run time.  Use -Wl,-z,undefs to override (which needs binutils binutils-2.29.1-12 at least).

This is very desirable for the Sun RPC removal, otherwise programs continue to build by accident.

I'm going to add this to the binutils change for Fedora 28, which is still pending Fesco approval:

https://fedoraproject.org/wiki/Changes/BINUTILS2291
Comment 1 Jens Petersen 2018-01-25 06:12:09 UTC 
This breaks ghc linking and also a lot of other stuff I gather.

Anyway I added a workaround to ghc-rpm-macros for now.
Comment 2 Igor Gnatenko 2018-01-25 06:58:47 UTC 
I don't think that we need to revert this, but fixing packages would take some time.

Florian, it would be nice to have some FAQ on wiki how to fix particular problems.
Comment 3 Florian Weimer 2018-01-25 08:16:31 UTC 
(In reply to Igor Gnatenko from comment #2)
> Florian, it would be nice to have some FAQ on wiki how to fix particular
> problems.

I added some documentation to:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md

Do you think this is sufficient?
Comment 4 Igor Gnatenko 2018-01-25 09:28:46 UTC 
(In reply to Florian Weimer from comment #3)
> (In reply to Igor Gnatenko from comment #2)
> > Florian, it would be nice to have some FAQ on wiki how to fix particular
> > problems.
> 
> I added some documentation to:
> 
> https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/
> buildflags.md
> 
> Do you think this is sufficient?

Looks good and I think is sufficient because important part is to be able to disable it and it's mentioned there.

But it would be nice to have some info what to do about plugins for example. Basically most common problems people are going to have.
Comment 5 Severin Gehwolf 2018-01-25 19:05:45 UTC 
FWIW, the fix for this bug made some issues surface in java-1.8.0-openjdk. See bug 1538767.
Comment 6 Florian Weimer 2018-01-29 14:30:00 UTC 
Reverted in rawhide.
Comment 7 Florian Weimer 2019-04-09 09:40:39 UTC 
I do not think we can make this change at this point.