Bug 1536677

Summary:	Simultaneous service catalog request do not honour quotas
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	Tina Fitzgerald <tfitzger>
Status:	CLOSED ERRATA	QA Contact:	Anurag <ansinha>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.7.0	CC:	akarol, ansinha, cpelland, dajohnso, dscott, gmccullo, igortiunov, jhardy, mfeifer, mkanoor, obarenbo, simaishi, smallamp, tfitzger, vparekh
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.9.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	quota:service
Fixed In Version:	5.9.3.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1456819	Environment:
Last Closed:	2018-07-12 13:14:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:	1456819
Bug Blocks:	1561041

Comment 2 CFME Bot 2018-01-19 22:07:32 UTC

New commit detected on ManageIQ/manageiq/gaprindashvili:
https://github.com/ManageIQ/manageiq/commit/e3afbf863f6d1b63fd8768b35963f8c5c8a8f0de

commit e3afbf863f6d1b63fd8768b35963f8c5c8a8f0de
Author:     Greg McCullough <gmccullo>
AuthorDate: Fri Jan 19 16:06:18 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Jan 19 17:00:36 2018 -0500

    Merge pull request #16831 from tinaafitz/active_provisions_using_requests
    
    Change the way active_provisions are calculated.
    (cherry picked from commit ca66301eac096b322395629d89ea24e74ca64e0a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536677

 app/models/mixins/miq_provision_quota_mixin.rb     | 26 ++-----
 spec/models/miq_provision_request_spec.rb          | 82 ++++++----------------
 ...ervice_template_provision_request_quota_spec.rb | 55 +++------------
 spec/support/service_template_helper.rb            |  3 +
 4 files changed, 41 insertions(+), 125 deletions(-)

Comment 3 Vatsal Parekh 2018-01-29 17:45:49 UTC

Able to verify this on Version 5.9.0.18.20180125190915_e0d341

Comment 5 Tina Fitzgerald 2018-02-02 15:30:01 UTC

Hi Vatsal,

I'm not able to access: https://10.8.198.64/

Thanks,
Tina

Comment 7 CFME Bot 2018-03-27 21:41:18 UTC

https://github.com/ManageIQ/manageiq/pull/17214

Comment 8 CFME Bot 2018-05-21 22:04:22 UTC

New commit detected on ManageIQ/manageiq-content/gaprindashvili:

https://github.com/ManageIQ/manageiq-content/commit/3e0fad2df561663e70894ddefffb8ac34fd91c68
commit 3e0fad2df561663e70894ddefffb8ac34fd91c68
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Wed Apr 18 15:31:51 2018 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Wed Apr 18 15:31:51 2018 -0400

    Merge pull request #203 from billfitzgerald0120/quota_overrides

    Calculate quota using service dialogs overrides.
    (cherry picked from commit daf5f5031dbe9b516350ae37a1d5a9f43ad1afa0)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536677

 content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/requested.rb | 59 +-
 spec/automation/unit/method_validation/calculate_requested_spec.rb | 99 +-
 2 files changed, 141 insertions(+), 17 deletions(-)

Comment 11 errata-xmlrpc 2018-07-12 13:14:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2184