Bug 1536954

Guest is win8.1-32.

Created attachment 1384223 [details]
qga-restart-service

Hi,

Unfortunatlly I cant reproduce this! can you test earlier versions of the win drivers and see if this reproduces?

(In reply to Sameeh Jubran from comment #4)
> Hi,
> 
> Unfortunatlly I cant reproduce this! can you test earlier versions of the
> win drivers and see if this reproduces?

It can actually be reproduced in my testing env.
1) I tried 3 times for win8-32 guest with latest driver(145) and qemu-ga(qemu-ga-win-7.5.0-2), hit this issue once.So it's not 100% reproduce.

2) Can reproduce it with virtio-win-prewhql-137 driver and  qemu-ga-win-7.4.5-1 on win8.1-64 guest.

Created attachment 1384778 [details]
qemu ga from current upstream

I have tried to reproduce many times, but I couldn't. It's interesting to see if this happens to upstream code too, can you please try and reproduce the issue with the attached build that I've built from upstream.

(In reply to Sameeh Jubran from comment #6)
> Created attachment 1384778 [details]
> qemu ga from current upstream
> 
> I have tried to reproduce many times, but I couldn't. It's interesting to
> see if this happens to upstream code too, can you please try and reproduce
> the issue with the attached build that I've built from upstream.

Can get error reply with your build. But vss service in guest is still running.


# nc -U /tmp/qga-bug.sock 

{"execute":"guest-ping"}
{"return": {}}
{"execute":"guest-fsfreeze-freeze"}
{"error": {"class": "GenericError", "desc": "timeout when try to receive Frozen event from VSS provider: Unspecified error"}}

Hi xiaoling,

This bug was already fixed on upstream in the following commit:
https://github.com/qemu/qemu/commit/4d80d20fe12248956c07587376f5b5a741f74aa2

I'll apply it and create a mockup build for you to test.

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15084654

(In reply to Sameeh Jubran from comment #11)
> https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15084654

It works like upstream version
steps:
1)boot up guest with qemu-ga installed.
2)do io test in c: disk
3)issue fsfreeze cmd
{"execute":"guest-fsfreeze-freeze"}
{"error": {"class": "GenericError", "desc": "timeout when try to receive Frozen event from VSS provider: Unspecified error"}}    --> expected

4)stop vss service in guest, no error info pop up.
5)check if qga works well
{"execute":"guest-ping"}
{"return": {}}


So, this bug is fixed in this build.

(In reply to xiagao from comment #13)
> (In reply to Sameeh Jubran from comment #11)
> > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15084654
> 
> It works like upstream version
> steps:
> 1)boot up guest with qemu-ga installed.
> 2)do io test in c: disk
> 3)issue fsfreeze cmd
> {"execute":"guest-fsfreeze-freeze"}
> {"error": {"class": "GenericError", "desc": "timeout when try to receive
> Frozen event from VSS provider: Unspecified error"}}    --> expected
> 
> 4)stop vss service in guest, no error info pop up.
> 5)check if qga works well
> {"execute":"guest-ping"}
> {"return": {}}
> 
> 
> So, this bug is fixed in this build.

Hi Sameeh,
From the return info, "Unspecified error" is not friendly, can we change it or delete it? and is the timeout 10s ?

{"error": {"class": "GenericError", "desc": "timeout when try to receive Frozen event from VSS provider: Unspecified error"}}

(In reply to xiagao from comment #14)
> (In reply to xiagao from comment #13)
> > (In reply to Sameeh Jubran from comment #11)
> > > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15084654
> > 
> > It works like upstream version
> > steps:
> > 1)boot up guest with qemu-ga installed.
> > 2)do io test in c: disk
> > 3)issue fsfreeze cmd
> > {"execute":"guest-fsfreeze-freeze"}
> > {"error": {"class": "GenericError", "desc": "timeout when try to receive
> > Frozen event from VSS provider: Unspecified error"}}    --> expected
> > 
> > 4)stop vss service in guest, no error info pop up.
> > 5)check if qga works well
> > {"execute":"guest-ping"}
> > {"return": {}}
> > 
> > 
> > So, this bug is fixed in this build.
> 
> Hi Sameeh,
> From the return info, "Unspecified error" is not friendly, can we change it
> or delete it? and is the timeout 10s ?
Yes
> 
> {"error": {"class": "GenericError", "desc": "timeout when try to receive
> Frozen event from VSS provider: Unspecified error"}}
I'll see what I can do =)

(In reply to xiagao from comment #14)
> (In reply to xiagao from comment #13)
> > (In reply to Sameeh Jubran from comment #11)
> > > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=15084654
> > 
> > It works like upstream version
> > steps:
> > 1)boot up guest with qemu-ga installed.
> > 2)do io test in c: disk
> > 3)issue fsfreeze cmd
> > {"execute":"guest-fsfreeze-freeze"}
> > {"error": {"class": "GenericError", "desc": "timeout when try to receive
> > Frozen event from VSS provider: Unspecified error"}}    --> expected
> > 
> > 4)stop vss service in guest, no error info pop up.
> > 5)check if qga works well
> > {"execute":"guest-ping"}
> > {"return": {}}
> > 
> > 
> > So, this bug is fixed in this build.
> 
> Hi Sameeh,
> From the return info, "Unspecified error" is not friendly, can we change it
> or delete it? and is the timeout 10s ?
Yes
> 
> {"error": {"class": "GenericError", "desc": "timeout when try to receive
> Frozen event from VSS provider: Unspecified error"}}
I'll see what I can do =)

I dont think we want to do this change as it will require change in qemu`s error
handling code and not just qga which will make qga different than upstream code. We can just delete it but this isn`t good approach either.

I think we can close this, please reopen in case you disagree.

(In reply to Sameeh Jubran from comment #10)
> Hi xiaoling,
> 
> This bug was already fixed on upstream in the following commit:
> https://github.com/qemu/qemu/commit/4d80d20fe12248956c07587376f5b5a741f74aa2
> 
> I'll apply it and create a mockup build for you to test.

We will test this bug on downstream build. So reopen it.

Verified this bug on mingw-qemu-ga-win-7.6.0-2.el7ev with win7-32 guest.
The steps are the same with comment 13.

{"execute":"guest-fsfreeze-freeze"}
{"error": {"class": "GenericError", "desc": "timeout when try to receive Frozen event from VSS provider: Unspecified error"}}

Xiaoling and Sameeh,

Looking into BZ#1596457 -> how different are the 2? Shouldn't one be a duplicate of another?

(In reply to Marina from comment #22)
> Xiaoling and Sameeh,
> 
> Looking into BZ#1596457 -> how different are the 2? Shouldn't one be a
> duplicate of another?

They are not different as they are resolved by the same patch and can be marked as duplicates. BZ#1596457 makes it clear on how to reproduce the issue as this hang happens in a heavy IO environment. I could easily reproduce the hang after manually simulating such an environment.

*** This bug has been marked as a duplicate of bug 1596457 ***