Bug 1537140
| Summary: | rubygem-bcrypt does not work (is FTBFS) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | libxcrypt | Assignee: | Björn Esser (besser82) <besser82> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | besser82, fweimer |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-bcrypt-3.1.11-8.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-16 08:34:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1537261 | ||
Ping? Could you please look into it? Hi Björn, Thx for fixing this. Does it mean that the libxcrypt is not 100% compatible with libcrypt and changes the return values intentionally? (In reply to Vít Ondruch from comment #3) > Hi Björn, > > Thx for fixing this. Does it mean that the libxcrypt is not 100% compatible > with libcrypt and changes the return values intentionally? Hi Vit, you're welcome! Well, the actual problem was not about so much about libxcrypt; there are no changes libxcrypt makes to any return value, but some internal implementations are different from glibc's libcrypt: On pure C-level it doesn't make any difference to the consuming code (return values are 100% binary compatible on this level and are conforming to ANSI-C standards). In this case the C-code of the built ruby-extension was the real problem, since it made the blunt assumption that the internal implementation of OpenWall's reference implementation would be the same for *any* other implementation as well: * The `bc_salt()` function was treating the return value of `crypt_gensalt()` as binary data instead as a valid C-string and thus it was full of trailing 0-bytes (libxcrypt uses a 192 byte sized char buffer as return value, which is perfectly valid for C-code as a 0-byte in a C-string terminates it). This broke most of the code and tests. * The `bc_crypt()` function was discarding the return value of `crypt()` and instead assumed the opaque (and thus implementation dependant) void-pointer (void can be any structure of data by the C-standard) to `data` would just return a valid C-string, when in fact the return value *is* a valid C-string with the wanted information for all implementations of `crypt()` implied by POSIX. I hope that this clarifies, what my patch does, a bit. Thx a lot for insights. |
Description of problem: rubygem-bcrypt is broken by libxcrypt Version-Release number of selected component (if applicable): $ rpm -q libxcrypt libxcrypt-4.0.0-0.203.20180120git3436e7b.fc28.x86_64 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: The rubygem-bcrypt build fails. What draw my attention from the build log is this test failure failure: ~~~ 2) Generating BCrypt hashes should be interoperable with other implementations Failure/Error: expect(BCrypt::Engine.hash_secret(secret, salt)).to eql(test_vector) expected: "$2a$05$CCCCCCCCCCCCCCCCCCCCC.E5YPO9kmyuRGyh0XouQYb4YMJKvyOeW" got: "$2a$05$CCCCCCCCCCCCCCCCCCCCC.E5YPO9kmyuRGyh0XouQYb4YMJKvyOeW\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00...x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" (compared using eql?) # /usr/share/gems/gems/rspec-support-3.7.0/lib/rspec/support.rb:97:in `block in <module:Support>' ... snip ... ~~~ As you can see, there are some unexpected null characters included at the end of the string. This is the code where libxcrypt is called: https://github.com/codahale/bcrypt-ruby/blob/master/ext/mri/crypt.c#L37 To me, it seems that the crypt_ra function does not sanitize either the "data" parameter or probably the "size" is wrong. Expected results: The rubygem-bcrypt test suite and the build must pass. Additional info: [1] https://apps.fedoraproject.org/koschei/package/rubygem-bcrypt