Bug 1537567

Summary: Dialog loading issue and Wrong redirect through custom button's associative dialog
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: eclarizi
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact:
Priority: high    
Version: 5.9.0CC: cpelland, gmccullo, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: Regression
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: custom_button:instance:dialog
Fixed In Version: 5.9.0.18 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1536204 Environment:
Last Closed: 2018-03-06 15:14:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1536204    
Bug Blocks:    

Comment 3 CFME Bot 2018-01-23 14:10:56 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:
https://github.com/ManageIQ/manageiq-ui-classic/commit/a3813c3744a84572cc3f9f12e5a16377a8893ed6

commit a3813c3744a84572cc3f9f12e5a16377a8893ed6
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Jan 22 16:08:56 2018 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Jan 23 09:06:06 2018 -0500

    Merge pull request #3298 from eclarizio/BZ1536204
    
    Fix for dialog loading issue and wrong redirect
    (cherry picked from commit 5408a4b5f8eefc6cf14be40c1bf861a3b70a4179)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1537567

 app/controllers/vm_common.rb                    |  3 +-
 app/services/dialog_local_service.rb            |  2 +-
 app/views/shared/dialogs/_dialog_user.html.haml |  2 ++
 spec/services/dialog_local_service_spec.rb      | 47 ++++++++++++++++++-------
 4 files changed, 39 insertions(+), 15 deletions(-)