Bug 1537572

 - Remove the old cruft, this is not needed in Fedora:

Group: 

BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

rm -rf %{buildroot} in %install

%clean
rm -rf %{buildroot}

%defattr(-,root,root,-) in %files


 - Use the correct systemd macros:

Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd

   and

BuildRequires: systemd-units
BuildRequires: systemd-devel


  should be simplified to:

%{?systemd_requires}
BuildRequires: systemd

 - Requires(pre): /usr/sbin/useradd is not needed as it is provided by shadow-utils just above.

 - %systemd_postun should be followed by the service file:

%systemd_postun corosync-qdevice.service

%systemd_postun corosync-qnetd.service

@Robert-André Mauchin:

Thank you a lot for the review.

I've fixed all issues with exception of 

BuildRequires: systemd-devel

because package is using libsystemd for sd_notify.

Fixed Spec URL: https://honzaf.fedorapeople.org/corosync-qdevice/corosync-qdevice.spec
Fixed SRPM URL: https://honzaf.fedorapeople.org/corosync-qdevice/corosync-qdevice-2.90.0-2.fc28.src.rpm
Fixed koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24414371

Thanks again for the review.

Package is approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
     generated", "MIT/X11 (BSD like)", "*No copyright* BSD (unspecified)",
     "BSD (3 clause)". 33 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/corosync-qdevice/review-
     corosync-qdevice/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/corosync
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     corosync-qnetd
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: corosync-qdevice-2.90.0-2.fc28.x86_64.rpm
          corosync-qdevice-debuginfo-2.90.0-2.fc28.x86_64.rpm
          corosync-qdevice-debugsource-2.90.0-2.fc28.x86_64.rpm
          corosync-qnetd-2.90.0-2.fc28.x86_64.rpm
          corosync-qdevice-2.90.0-2.fc28.src.rpm
corosync-qdevice.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit
corosync-qdevice.x86_64: E: non-standard-dir-perm /etc/corosync/qdevice/net 770
corosync-qdevice.x86_64: E: dir-or-file-in-var-run /var/run/corosync-qdevice
corosync-qdevice.x86_64: E: non-standard-dir-perm /var/run/corosync-qdevice 770
corosync-qdevice.x86_64: W: empty-%postun
corosync-qdevice-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
corosync-qdevice-debugsource.x86_64: W: no-documentation
corosync-qnetd.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit
corosync-qnetd.x86_64: W: non-standard-uid /etc/corosync/qnetd coroqnetd
corosync-qnetd.x86_64: W: non-standard-gid /etc/corosync/qnetd coroqnetd
corosync-qnetd.x86_64: E: non-standard-dir-perm /etc/corosync/qnetd 770
corosync-qnetd.x86_64: W: non-standard-uid /var/run/corosync-qnetd coroqnetd
corosync-qnetd.x86_64: W: non-standard-gid /var/run/corosync-qnetd coroqnetd
corosync-qnetd.x86_64: E: dir-or-file-in-var-run /var/run/corosync-qnetd
corosync-qnetd.x86_64: E: non-standard-dir-perm /var/run/corosync-qnetd 770
corosync-qnetd.x86_64: W: empty-%postun
corosync-qdevice.src: W: spelling-error %description -l en_US init -> unit, int, nit
5 packages and 0 specfiles checked; 7 errors, 10 warnings.

Thank you for the review and approval.

Regards,
  Honza

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/corosync-qdevice