Bug 1537593

Summary:	OPENSHIFT_DEFAULT_REGISTRY is deprecated, we need use REGISTRY_OPENSHIFT_SERVER_ADDR in the DC of docker-registry
Product:	OpenShift Container Platform	Reporter:	Wang Haoran <haowang>
Component:	Installer	Assignee:	Ben Parees <bparees>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Wang Haoran <haowang>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.9.0	CC:	aos-bugs, dyan, jialiu, jokerman, mmccomas, smunilla, wmeng, wzheng
Target Milestone:	---
Target Release:	3.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-ansible-3.9.14-1.git.0.ca2cfc3.el7.noarch.rpm	Doc Type:	Bug Fix
Doc Text:	Cause: Ansible installer was using a deprecated value ( OPENSHIFT_DEFAULT_REGISTRY) to set the registry url on the registry deployment. Consequence: A warning message about the deprecated value being used was reported. Fix: Updated the installer to use the preferred variable name (REGISTRY_OPENSHIFT_SERVER_ADDR) Result: The warning is no longer displayed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-18 18:06:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Wang Haoran 2018-01-23 14:53:42 UTC

Description of problem:
OPENSHIFT_DEFAULT_REGISTRY is deprecated, we need use REGISTRY_OPENSHIFT_SERVER_ADDR in the DC of docker-registry
Version-Release number of the following components:
rpm -q openshift-ansible
rpm -q ansible
ansible --version

How reproducible:
always
Steps to Reproduce:
1.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated

Expected results:

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 openshift-github-bot 2018-01-24 21:23:06 UTC

Commit pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/0da4565f55faeb436b5a4634a1f57d18ffb7e0c4
use non-deprecated REGISTRY_OPENSHIFT_SERVER_ADDR variable to set the registry hostname

bug 1537593

https://bugzilla.redhat.com/show_bug.cgi?id=1537593

Comment 3 Wang Haoran 2018-01-29 07:04:43 UTC

Verified with:
oc v3.9.0-0.31.0
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://172.16.120.121:8443
openshift v3.9.0-0.31.0
kubernetes v1.9.1+a0ce1bc65

# oc env dc/docker-registry --list
# deploymentconfigs docker-registry, container registry
REGISTRY_HTTP_ADDR=:5000
REGISTRY_HTTP_NET=tcp
REGISTRY_HTTP_SECRET=IIU2by2wJ87Gu0HExgVvUAGqbaSD7HUpPZn3xLm+oc4=
REGISTRY_MIDDLEWARE_REPOSITORY_OPENSHIFT_ENFORCEQUOTA=false
REGISTRY_HTTP_TLS_KEY=/etc/secrets/registry.key
REGISTRY_OPENSHIFT_SERVER_ADDR=docker-registry.default.svc:5000
REGISTRY_CONFIGURATION_PATH=/etc/registry/config.yml
REGISTRY_HTTP_TLS_CERTIFICATE=/etc/secrets/registry.crt

Comment 4 Johnny Liu 2018-01-29 10:15:03 UTC

The fix PR is landed into openshift-ansible-roles-3.9.0-0.31.0.git.0.e0a0ad8.el7.noarch, but does not land into openshift-ansible master branch, pls also help fix it in master branch.

Comment 5 Ben Parees 2018-01-29 16:52:01 UTC

This change actually had to be reverted:
https://github.com/openshift/openshift-ansible/pull/6913

i'll move this back to QA once we unrevert that change.

Comment 6 Ben Parees 2018-01-29 18:19:06 UTC

new PR is here:
https://github.com/openshift/openshift-ansible/pull/6923

Comment 8 Scott Dodson 2018-03-22 12:40:54 UTC

In openshift-ansible-3.9.9-1

Comment 9 Wang Haoran 2018-03-23 03:06:13 UTC

verified with ansible:
openshift-ansible-3.9.14-1.git.0.ca2cfc3.el7.noarch.rpm 

and openshift version:
openshift v3.9.14
kubernetes v1.9.1+a0ce1bc657
etcd 3.2.16