Bug 1537797

Summary: mock: Missing " causes error after enabling package signing
Product: [Fedora] Fedora EPEL Reporter: Phil Wyett <philip.wyett>
Component: mockAssignee: Miroslav Suchý <msuchy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: epel7CC: jdisnard, jkeating, mebrown, msimacek, msuchy, praiskup, tmz, williams
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: mock-1.4.9-1.fc27 mock-1.4.9-1.fc26 mock-1.4.9-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-20 17:15:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Phil Wyett 2018-01-23 22:20:55 UTC
Description of problem:

mock: Missing '"' causes error after enabling package signing.

Line: 247.

Version-Release number of selected component (if applicable):

1.4.8-1.el7

How reproducible:

Always.

Steps to Reproduce:
1. Install/enable EPEL and then install 'mock'.
2. Edit '/etc/mock/site-defaults.cfg' and enable package signing - line 241 to 247. Configure as required for personal needs.
3. Try build a package.

Actual results:

Unexpected EOF missing '"'

Expected results:

When configured correctly, packages should be signed without error.

Additional info:

Add: " before ' at end of line 247 to fix - String not closed.

Comment 1 Todd Zullinger 2018-01-24 01:07:54 UTC
In case it's helpful to the mock maintainer(s), I filed the trivial fix as a GitHub pull-request: https://github.com/rpm-software-management/mock/pull/157

Comment 2 Phil Wyett 2018-01-25 20:38:53 UTC
(In reply to Todd Zullinger from comment #1)
> In case it's helpful to the mock maintainer(s), I filed the trivial fix as a
> GitHub pull-request: https://github.com/rpm-software-management/mock/pull/157

If I had been paying slightly more attention than fixing it locally and doing this bug report to check where upstream was, I may have done the PR as well. Thanks Todd, I also hope your PR is helpful for the maintainers.

Comment 3 Fedora Update System 2018-02-12 20:24:17 UTC
mock-1.4.9-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c17daa06f6

Comment 4 Fedora Update System 2018-02-12 20:24:34 UTC
mock-1.4.9-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fdd5d935df

Comment 5 Fedora Update System 2018-02-12 20:24:52 UTC
mock-1.4.9-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-5d1f3c3e39

Comment 6 Fedora Update System 2018-02-13 16:21:47 UTC
mock-1.4.9-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fdd5d935df

Comment 7 Fedora Update System 2018-02-13 16:41:25 UTC
mock-1.4.9-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c17daa06f6

Comment 8 Fedora Update System 2018-02-13 18:17:33 UTC
mock-1.4.9-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-5d1f3c3e39

Comment 9 Fedora Update System 2018-02-20 17:15:01 UTC
mock-1.4.9-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2018-02-27 16:53:25 UTC
mock-1.4.9-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-02-27 20:39:55 UTC
mock-1.4.9-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.