Bug 1537947

Summary:	rcs build fails
Product:	[Fedora] Fedora	Reporter:	Need Real Name <mal>
Component:	rcs	Assignee:	Matej Mužila <mmuzila>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	27	CC:	hhorak, jmoskovc, mmuzila
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rcs-5.9.4-9.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-17 00:14:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Need Real Name 2018-01-24 07:09:14 UTC

Building rcs from rawhide on F26,F27 and other fails:
 rpmbuild --rebuild rcs-5.9.4-5.fc26.src.rpm
...
PASS: t805
FAIL: t810
PASS: t900
....
cd ~/rpmbuild/BUILD/rcs-5.9.4/tests/t810.d/
cat out 
t810.d/x,v  -->  t810.d/x
revision 4.21 (locked)
done
t810.d/x,v  <--  t810.d/x
new revision: 4.22; previous revision: 4.21
done
PROBLEM: t810.d/x newer than t810.d/x,v

ls shows that the difference is in nanoseconds part of the file timestamp:
the file x,v has 0 nanoseconds set by the rcs, and x has nanoseconds set by the OS.

ls -ltr --time-style='+%F %T.%N'
total 12
-r--r--r--. 1 mal mal 432 2018-01-24 02:03:05.000000000 x,v
-rw-r--r--. 1 mal mal  27 2018-01-24 02:03:05.526446950 x
-rw-r--r--. 1 mal mal 169 2018-01-24 02:03:05.531446982 out

Comment 1 Need Real Name 2018-03-23 06:33:42 UTC

rcs-5.9.4-5.fc26.src.rpm                           20-Feb-2018 11:50    798K
still fails with the same "FAIL: t810" error

Comment 2 Fedora Update System 2018-03-27 14:00:37 UTC

rcs-5.9.4-9.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ce910523f

Comment 3 Fedora Update System 2018-03-27 17:54:09 UTC

rcs-5.9.4-9.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0ce910523f

Comment 4 Need Real Name 2018-03-27 19:27:08 UTC

This is an issue with rcs nanoseconds time handling https://lists.gnu.org/archive/html/bug-rcs/2017-10/msg00007.html
it was probably fixed in branch "p": http://git.savannah.gnu.org/cgit/rcs.git/?h=p

Comment 5 Fedora Update System 2018-04-17 00:14:15 UTC

rcs-5.9.4-9.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Need Real Name 2018-05-19 19:26:02 UTC

This bug (t810 failure) seems to be fixed in git://git.savannah.gnu.org/rcs.git branch "next". But you need to compile the code with -O0 to get working rcs, otherwise gcc miscompiles it.