Bug 1537955

Summary: Cannot access the route of Mediawiki123 while provision with same username/passwd
Product: OpenShift Container Platform Reporter: Zhang Cheng <chezhang>
Component: Service BrokerAssignee: Erik Nelson <ernelson>
Status: CLOSED ERRATA QA Contact: Zhang Cheng <chezhang>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.9.0CC: aos-bugs, dzager, ernelson, jmatthew
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-28 14:22:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zhang Cheng 2018-01-24 07:33:25 UTC
Description of problem: 
Cannot access the route of Mediawiki123 while provision with same username/passwd, and no any warning or error in console and beckend. This issue was mentioned in below two bugs, but were not fixed in both of them.
https://bugzilla.redhat.com/show_bug.cgi?id=1471730
https://bugzilla.redhat.com/show_bug.cgi?id=1472226


How reproducible:
Always

Steps to Reproduce:
1. Provision mediawiki(APB) with same "Mediawiki Admin User" and "Mediawiki Admin User Password" in web console.
2. Provision postgresql(APB) in web console.
3. Create servicebinding and add secret to mediawiki application.
4. Try to access the route of Mediawiki123

Actual results:  
Cannot access the route of Mediawiki123.

Expected results: 
Can access the route of Mediawiki123

addition info: 
None

Comment 2 Zhang Cheng 2018-02-07 03:10:10 UTC
Attach relate pr: https://github.com/ansibleplaybookbundle/mediawiki-apb/pull/23

Comment 3 Zhang Cheng 2018-02-07 08:16:28 UTC
QE will cover below while downstream image ready for test:
1. Confirm APB's display name have alert about the two values cannot be the same
2. Try to provision with same name and passwd, the first task of the APB should fail with an explicit message and cease execution.

Comment 5 Zhang Cheng 2018-02-23 05:42:58 UTC
In my testing, mediawiki provision failed with an explicit message while using same name and passwd. It is OKay for me.

TASK [mediawiki : Validate Admin User and Password] ****************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Mediawiki Admin User and Password cannot be the same value!"}

But, the image of mediawiki seem not latest from stage registry, I think "title" of "mediawiki_admin_user" should be "Mediawiki Admin User (Cannot be the same value as Admin User Password)". Test result is "Mediawiki Admin User".

# oc describe clusterserviceplan 43d3e23d214c26dbebc0879e44425db4
Name:         43d3e23d214c26dbebc0879e44425db4
Namespace:    
Labels:       <none>
Annotations:  <none>
API Version:  servicecatalog.k8s.io/v1beta1
Kind:         ClusterServicePlan
Metadata:
  Creation Timestamp:  2018-02-23T05:24:30Z
  Resource Version:    164262
  Self Link:           /apis/servicecatalog.k8s.io/v1beta1/clusterserviceplans/43d3e23d214c26dbebc0879e44425db4
  UID:                 d332d4ad-1859-11e8-b0a2-0a580a800006
Spec:
  Cluster Service Broker Name:  ansible-service-broker
  Cluster Service Class Ref:
    Name:       03b69500305d9859bb9440d9f9023784
  Description:  An APB that deploys MediaWiki
  External ID:  43d3e23d214c26dbebc0879e44425db4
  External Metadata:
    Cost:              $0.00
    Display Name:      Default
    Long Description:  This plan deploys a single mediawiki instance without a DB
    Schemas:
      Service _ Binding:
        Create:
          Openshift _ Form _ Definition:
      Service _ Instance:
        Create:
          Openshift _ Form _ Definition:
            mediawiki_db_schema
            mediawiki_site_name
            mediawiki_site_lang
            mediawiki_admin_user
            Key:   mediawiki_admin_pass
            Type:  password
        Update:
  External Name:  default
  Free:           true
  Instance Create Parameter Schema:
    $ Schema:               http://json-schema.org/draft-04/schema
    Additional Properties:  false
    Properties:
      Mediawiki _ Admin _ Pass:
        Title:  Mediawiki Admin User Password
        Type:   string
      Mediawiki _ Admin _ User:
        Default:  admin
        Title:    Mediawiki Admin User
        Type:     string
      Mediawiki _ Db _ Schema:
        Default:  mediawiki
        Pattern:  ^[a-zA-Z_][a-zA-Z0-9_]*$
        Title:    Mediawiki DB Schema
        Type:     string
      Mediawiki _ Site _ Lang:
        Default:  en
        Pattern:  ^[a-z]{2,3}$
        Title:    Mediawiki Site Language
        Type:     string
      Mediawiki _ Site _ Name:
        Default:  MediaWiki
        Pattern:  ^[a-zA-Z]+$
        Title:    Mediawiki Site Name
        Type:     string
    Required:
      mediawiki_db_schema
      mediawiki_site_name
      mediawiki_site_lang
      mediawiki_admin_user
      mediawiki_admin_pass
    Type:  object
  Instance Update Parameter Schema:
    $ Schema:               http://json-schema.org/draft-04/schema
    Additional Properties:  false
    Properties:
      Mediawiki _ Site _ Name:
        Default:  MediaWiki
        Pattern:  ^[a-zA-Z]+$
        Title:    Mediawiki Site Name
        Type:     string
    Required:
      mediawiki_site_name
    Type:  object
  Service Binding Create Parameter Schema:
    $ Schema:               http://json-schema.org/draft-04/schema
    Additional Properties:  false
    Type:                   object
Status:
  Removed From Broker Catalog:  false
Events:                         <none>

Comment 6 Zhang Cheng 2018-02-23 05:48:48 UTC
@Erik,
In my first going through, I think mediawiki apb image need update and changing status to "MODIFIED". Please correct me if I have a mistake. Thanks.

Comment 8 Erik Nelson 2018-02-23 14:21:02 UTC
I am not sure how the downstream images are built, but it looks like the label may not have been updated on the image. I will look into this today.

Comment 9 David Zager 2018-02-23 20:00:37 UTC
The downstream apb.yml and mediawiki-apb image have been updated in brew.

brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/mediawiki-apb:v3.9.0-0.51.0.1

You can check the release label on the latest image to identify the image more easily.

$ docker inspect brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift3/mediawiki-apb:latest --format "{{ index .Config.Labels.release }}"
0.51.0.1

Comment 10 Zhang Cheng 2018-02-24 01:14:25 UTC
I'm changing status to "MODIFIED" since image of mediawiki-apb not ready for test in stage registry.

The latest from Stage Registry: "release": "0.47.0.0"

Comment 11 Zhang Cheng 2018-02-27 06:08:36 UTC
Changing status to ON_QA since image ready for test.

Comment 12 Zhang Cheng 2018-02-27 06:10:46 UTC
Verified and Passed with mediawiki-apb:v3.9.0-0.53.0.0 from stage registry.
1. mediawiki provision failed with an explicit message while using same name and passwd. It is OKay for me.
2. clusterserviceplan and web console in provision page have "Mediawiki Admin User (Cannot be the same value as Admin User Password)"

Comment 15 errata-xmlrpc 2018-03-28 14:22:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489