Bug 1538044

Summary: [trello lo6HwQgu] "Create New Webhook Secret" modal disappears after mouse click outside
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: medium    
Version: 3.9.0CC: aos-bugs, jforrest, jokerman, mmccomas, spadgett
Target Milestone: ---   
Target Release: 3.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-01-29 12:45:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xingxing Xia 2018-01-24 10:56:48 UTC
Description of problem:
"Create New Webhook Secret" modal disappears after mouse click outside

Version-Release number of selected component (if applicable):
v3.9.0-0.23.0

How reproducible:
Always

Steps to Reproduce:
1. Go to BC edit page "Triggers" part, click "Create New Webhook Secret" and mouses click outside

Actual results:
1. Modal disappears

Expected results:
1. Modal should keep, in consistency with other modals

Additional info:

Comment 1 Jessica Forrester 2018-01-24 13:38:50 UTC
@jhadvig steve just changed the other ones as part of https://github.com/openshift/origin-web-console/pull/2700/files

Should probably be consistent for now.

We are generally looking at the differences in modal behavior in https://github.com/openshift/origin-web-console/issues/2661

Comment 2 openshift-github-bot 2018-01-24 14:59:29 UTC
Commits pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/b8a668d9d1d4532d7df8f379d9e56420c904b12b
Bug 1538044: Dont dismiss create webhook secret modal when clicking outside the modal

https://github.com/openshift/origin-web-console/commit/af52dc1114b16b99c381521b7191f8152ffce68d
Merge pull request #2711 from jhadvig/bz1538044

Automatic merge from submit-queue.

Bug 1538044: Dont dismiss create webhook secret modal when clicking outside the modal

@jwforres PTAL

Comment 3 Jakub Hadvig 2018-01-24 15:26:14 UTC
Fixing PR: https://github.com/openshift/origin-web-console/pull/2711

Comment 7 Xingxing Xia 2018-01-29 04:43:04 UTC
In v3.9.0-0.31.0 web console, the modal don't disappear after mouse clicks outside