Bug 1538389

Summary:	Node IP update should update Host IP in HostSubnet resource
Product:	OpenShift Container Platform	Reporter:	Ravi Sankar <rpenta>
Component:	Networking	Assignee:	Ravi Sankar <rpenta>
Status:	CLOSED ERRATA	QA Contact:	Hongan Li <hongli>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.6.0	CC:	aos-bugs, bbennett, bmeng, hongli
Target Milestone:	---
Target Release:	3.9.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: HostSubnet was not updated with new Node IP Consequence: openshift-node service fails to start Fix: openshift master to update HostSubnet when the node IP changes Result: openshift-node service works as expected	Story Points:	---
Clone Of:
Clones:	1585766 1585767 1585768 (view as bug list)		Environment:
Last Closed:	2018-03-28 14:22:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1585766, 1585767, 1585768

Description Ravi Sankar 2018-01-25 01:03:02 UTC

Description of problem:
Node IP addr is updated but SDN master failed to update corresponding HostSubnet record.

Version-Release number of selected component (if applicable):
oc v3.9.0-alpha.3+57f5a29-160-dirty
kubernetes v1.9.1+a0ce1bc657

How reproducible:
Always

Steps to Reproduce:
1. Assume node has IP1 and IP2 ip addresses
2. Set hostname as IP1 and start openshift node and openshift master service
3. Update node addr to IP2 by using nodeIP config param in node-config.yaml
4. Restart openshift node service

Actual results:
Openshift node service fails with unable to fetch local subnet.

Expected results:
Openshift node should start with new IP addr

Additional info:

Comment 1 Ravi Sankar 2018-01-25 01:11:22 UTC

This is side effect of https://bugzilla.redhat.com/show_bug.cgi?id=1438402
When node IP is updated, we must update host IP in HostSubnet record otherwise updated node will be out of sync with other nodes in the cluster.
To avoid node flip flop in case of multiple node IPs, we should always specify nodeIP config option in node-config.yaml

Comment 2 Ravi Sankar 2018-01-25 01:47:37 UTC

Fixed by https://github.com/openshift/origin/pull/18281

Comment 3 openshift-github-bot 2018-01-30 11:13:37 UTC

Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/48a01225a8f693902904b30d72d51e390f8ab708
Merge pull request #18281 from pravisankar/fix-master-nodeevent

Automatic merge from submit-queue.

Bug 1538389 - Allow node IP change to update Host IP in HostSubnet resource

- Node status addresses may have both old and new IP address and by
validating against these addrs we may not be able to update HostSubnet
with new node IP. Openshift node service waits for its HostSubnet resource
with new Host IP and eventually fails.

- This change fixes the above issue by reverting the change for node flip/flop.
Recommended/correct way to handle node flip/flop case is to specify nodeIP config option in node-config.yaml

Comment 5 Hongan Li 2018-02-06 09:47:11 UTC

verified in openshift v3.9.0-0.38.0 and issue has been fixed.

the hostsubnet is updated after updating nodeIP in node-config.yaml and restarting node service.

Comment 8 errata-xmlrpc 2018-03-28 14:22:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0489